From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933700AbcCNHlF (ORCPT ); Mon, 14 Mar 2016 03:41:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:55941 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397AbcCNHlA (ORCPT ); Mon, 14 Mar 2016 03:41:00 -0400 Subject: Re: [PATCH 12/22] sun3_scsi: Adopt NCR5380.c core driver To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160314042700.596192247@telegraphics.com.au> <20160314042703.755991758@telegraphics.com.au> Cc: Ondrej Zary , Sam Creasey From: Hannes Reinecke Message-ID: <56E66B0A.3050702@suse.de> Date: Mon, 14 Mar 2016 08:40:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160314042703.755991758@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/14/2016 05:27 AM, Finn Thain wrote: > Add support for the custom Sun 3 DMA logic to the NCR5380.c core driver. > This code is copied from atari_NCR5380.c. > > Signed-off-by: Finn Thain > > --- > > The Sun 3 DMA code is still configured by macros. I have simplified things > slightly but I have avoided more ambitious refactoring. It's not clear to > me what that should look like and I can't test sun3_scsi anyway. At least > this permits the removal of atari_NCR5380.c. > > --- > drivers/scsi/NCR5380.c | 131 +++++++++++++++++++++++++++++++++++++++++++---- > drivers/scsi/sun3_scsi.c | 8 +- > 2 files changed, 124 insertions(+), 15 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)