From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933788AbcCNHtU (ORCPT ); Mon, 14 Mar 2016 03:49:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:56629 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933603AbcCNHtN (ORCPT ); Mon, 14 Mar 2016 03:49:13 -0400 Subject: Re: [PATCH 20/22] atari_scsi: Set a reasonable default for cmd_per_lun To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160314042700.596192247@telegraphics.com.au> <20160314042705.846189331@telegraphics.com.au> Cc: Ondrej Zary , Sam Creasey From: Hannes Reinecke Message-ID: <56E66CF5.2070200@suse.de> Date: Mon, 14 Mar 2016 08:49:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160314042705.846189331@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/14/2016 05:27 AM, Finn Thain wrote: > This setting does not need to be conditional on Atari ST or TT. > > Without TCQ support, cmd_per_lun == 2 is probably reasonable... > > Signed-off-by: Finn Thain > > --- > drivers/scsi/atari_scsi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > Index: linux/drivers/scsi/atari_scsi.c > =================================================================== > --- linux.orig/drivers/scsi/atari_scsi.c 2016-03-14 15:26:45.000000000 +1100 > +++ linux/drivers/scsi/atari_scsi.c 2016-03-14 15:26:55.000000000 +1100 > @@ -750,6 +750,7 @@ static struct scsi_host_template atari_s > .eh_abort_handler = atari_scsi_abort, > .eh_bus_reset_handler = atari_scsi_bus_reset, > .this_id = 7, > + .cmd_per_lun = 2, > .use_clustering = DISABLE_CLUSTERING, > .cmd_size = NCR5380_CMD_SIZE, > }; _2_ ? Are you being overly cheeky here? I sincerely doubt the driver is capable of submitting two simultaneous commands ... Care to explain? Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)