From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62F9CC43334 for ; Mon, 18 Jul 2022 20:33:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235972AbiGRUdz (ORCPT ); Mon, 18 Jul 2022 16:33:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235930AbiGRUdx (ORCPT ); Mon, 18 Jul 2022 16:33:53 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9877614C for ; Mon, 18 Jul 2022 13:33:51 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id va17so23532819ejb.0 for ; Mon, 18 Jul 2022 13:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kohlschutter-com.20210112.gappssmtp.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sSv2PAexsfUE9wq4Vnr5gzIcjcTTTaBz8dE26papfHA=; b=IJJcCEXhNxNmtiDW2OGrGVBpaFveJy/2+ca0zyYvkL0RyBQDhIpY8uCp607SqjC67d cer5uPHuB2hckfieCG89+jhd/m8haca5WABkZrhz8amgU7mWStKRNrw8s8oDR+jwR8a7 mLdxl/woBcmoQ3H+Ftn55L/gWKLubVRv0UQtpb9vwEYyhTVbqEyTI/fbpzca1hPluQ53 g12tYdpM4/5B3gfwAZMoFZcA2deW+VcqDKTwvadM6/AqXzP/3645ba5JYqaVN0nSQk3N G/CDnJMjvpAx3Z3zpBmA0ziBFb0WjTFF4iqXLyE00tIGg8/0qJ2bvXKdpNcI5fGROykV cvgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sSv2PAexsfUE9wq4Vnr5gzIcjcTTTaBz8dE26papfHA=; b=Ae1VG96XmIXiPyaVTDEhrHV1MVuP3WgDFpU9wIwrGHakS5G+pyhN5eeT0ZrKzahV8i JaV/RT/uT3tMXmVqqnHaojMVmRhoqCIvjgbM24+rLKeR66zTJGQHEW71/VvtaZbP3XOq v+IPahyXsilMjJHUvQo1Fb5hH7JqVRPLBCk49o0TGWS58s5kqbhfUNvPJsGJO+YWWrh3 TKXM8EGueo3S1JUUghTQxVkoSGyqf2AraJXOnGxske5CR7Hborpgnd8u/j/dAoZJJkc4 3htvoyXCccZ+apsqycOm4OoxrZ6wHILiI+/XF7Cdq823B29I2bdlNrBK8dZ8pY8urXFA e6dQ== X-Gm-Message-State: AJIora8ZypD2iC5Zo/J8dsfm4u2fST30BNyGCTJMvFCullkcuC9sPZ6o h8eBCRekLHEdJcL86W6Vc3UuoA== X-Google-Smtp-Source: AGRyM1uYoMKL4o8fEJPcZOlazCzJbfp4VNHRO5l1QjQlmBXCZz8CQv+PVr1YcoLXLQMjpIdnF70/jA== X-Received: by 2002:a17:907:62a6:b0:6ef:8118:d3e2 with SMTP id nd38-20020a17090762a600b006ef8118d3e2mr26685388ejc.605.1658176430371; Mon, 18 Jul 2022 13:33:50 -0700 (PDT) Received: from smtpclient.apple (ip5b434222.dynamic.kabel-deutschland.de. [91.67.66.34]) by smtp.gmail.com with ESMTPSA id bc4-20020a056402204400b0043a78236cd2sm9238603edb.89.2022.07.18.13.33.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jul 2022 13:33:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH] [REGRESSION] ovl: Handle ENOSYS when fileattr support is missing in lower/upper fs From: =?utf-8?Q?Christian_Kohlsch=C3=BCtter?= In-Reply-To: Date: Mon, 18 Jul 2022 22:33:48 +0200 Cc: Miklos Szeredi , overlayfs , linux-kernel , linux-fsdevel Content-Transfer-Encoding: quoted-printable Message-Id: <56E6CAAE-FF25-4898-8F9D-048164582E7B@kohlschutter.com> References: <4B9D76D5-C794-4A49-A76F-3D4C10385EE0@kohlschutter.com> <83A29F9C-1A91-4753-953A-0C98E8A9832C@kohlschutter.com> To: Linus Torvalds X-Mailer: Apple Mail (2.3696.100.31) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 18.07.2022 um 22:12 schrieb Linus Torvalds = : >=20 > On Mon, Jul 18, 2022 at 12:28 PM Miklos Szeredi = wrote: >>=20 >> So this is a bug in the kernel part of fuse, that doesn't catch and >> convert ENOSYS in case of the ioctl request. >=20 > Ahh, even better. No need to worry about external issues. >=20 > Linus My concern was fixing it in fuse instead of ovl would leave non-fuse = filesystems affected (even though I don't have proof that such = filesystems exist). I'm glad you are OK with Miklos' change; the outcome of this discussion = certainly adds some nuance to the famous "don't break userspace" / error = code thread from 2012. Best, Christian