From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] regulator: Fix deadlock during regulator registration
Date: Wed, 30 Mar 2016 19:38:29 -0400 [thread overview]
Message-ID: <56FC6375.4060607@osg.samsung.com> (raw)
In-Reply-To: <20160330233427.GZ2350@sirena.org.uk>
Hello Mark,
On 03/30/2016 07:34 PM, Mark Brown wrote:
> On Wed, Mar 30, 2016 at 07:25:49PM -0400, Javier Martinez Canillas wrote:
>
>> You are doing some cleanup of the clean and scrub error paths by removing
>> rdev and returning ERR_PTR(ret) directly. I believe that should be in a
>> separate patch since is not related to the fix.
>
> There needs to be some reorganization due to the movement with the mutex
> handling.
>
Yes, I know. My point was that besides the reorganization that is needed,
he is removing some variables and that seemed like a separate change to me.
But of course you are the maintainer so ignore my comment if you don't mind
about that.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
prev parent reply other threads:[~2016-03-30 23:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 16:09 Jon Hunter
2016-03-30 16:18 ` Mark Brown
2016-03-30 16:46 ` Jon Hunter
2016-03-30 17:00 ` Mark Brown
2016-03-30 17:41 ` Jon Hunter
2016-03-30 23:25 ` Javier Martinez Canillas
2016-03-30 23:34 ` Mark Brown
2016-03-30 23:38 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC6375.4060607@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome