mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: azey <me@azey.net>
Cc: Jakub Kicinski <kuba@kernel.org>,
	David Ahern <dsahern@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	netdev <netdev@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net/ipv6: allow device-only routes via the multipath API
Date: Fri, 28 Nov 2025 17:28:41 +0100	[thread overview]
Message-ID: <56a0ec5c-da92-4f92-9697-71127866049b@6wind.com> (raw)
In-Reply-To: <19acb2c1318.fb2ad2c5200221.6191734529593487240@azey.net>

Le 28/11/2025 à 16:54, azey a écrit :
>> On 2025-11-28 09:38:07 +0100  Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
>>> With IPv6, unlike IPv4, the ECMP next hops can be added one by one. Your commit
>>> doesn't allow this:
> 
> Hold on, I think I understand what you actually meant by this, sorry.
> I got too focused on regressions from the discussion in v1, I'll make
> a v3 of the patch that allows dev-only routes to be added via append.
Yes, that is what I pointed out.

Please, add some self-tests to show that there is no regression. You probably
have to test different combinations of NLM_F_* flags. See:

https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/ip/iproute.c#n2418

  reply	other threads:[~2025-11-28 16:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 13:52 azey
2025-11-25  3:00 ` Jakub Kicinski
2025-11-25  3:15   ` azey
2025-11-25  3:25     ` Jakub Kicinski
2025-11-25  4:00       ` azey
2025-11-25  4:20         ` Jakub Kicinski
2025-11-25  5:30           ` azey
2025-11-26 17:51   ` azey
2025-11-27  7:58     ` Nicolas Dichtel
2025-11-27 14:06       ` azey
2025-11-28  8:38         ` Nicolas Dichtel
2025-11-28 12:38           ` azey
2025-11-28 13:22             ` azey
2025-11-28 15:28             ` Nicolas Dichtel
2025-11-28 15:45               ` azey
2025-11-28 15:54                 ` azey
2025-11-28 16:28                   ` Nicolas Dichtel [this message]
2025-11-28 17:49                     ` azey
2025-12-01 15:38                       ` Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56a0ec5c-da92-4f92-9697-71127866049b@6wind.com \
    --to=nicolas.dichtel@6wind.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@azey.net \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®