From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3435EB64D9 for ; Mon, 10 Jul 2023 08:07:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232599AbjGJIHb (ORCPT ); Mon, 10 Jul 2023 04:07:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbjGJIHY (ORCPT ); Mon, 10 Jul 2023 04:07:24 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E20F0120 for ; Mon, 10 Jul 2023 01:07:22 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1C05066057B8; Mon, 10 Jul 2023 09:07:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688976441; bh=+CLA7waOBRi0uCirQwBlUTqDiM39D3GMSmgXcTkwD4c=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TI6UdQkKLMMlrvJSdXLC9IH4O9YMQpgO+OklDPxYvjs7Bijql4dTuQPyP8T5tPHJt 6JsanwVgWixeGdz8+lBPCZ3Q+qN6FQyx/PxhSxrEdQAvwPA83gV9AtsAROCvIEaQgV ZPuwwa4CN91KgL2mVqGVmDA7kAEf32OKhV/d2/IhCV38bvHkZObQV0uK7JuPRWL8w5 J4edFHixQX848ItrgjpkQnsjyUkceWEGnQaOUQdpY23nDIewUIwBqJBLP8Vx0Pb2RR Ipf+aLcgvJjRXq7LEwUD4tDV9+UfG8QOOofFkvrUwwiBKZT3PNBXrIO8PLbN0jKut5 Yfiw98o0SvYXQ== Message-ID: <56a8fc90-337b-5ac2-be13-5420f2de6c5a@collabora.com> Date: Mon, 10 Jul 2023 10:07:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 2/2] drm/mediatek: Fix iommu fault during crtc enabling Content-Language: en-US To: "Jason-JH.Lin" , Chun-Kuang Hu , Alexandre Mergnat Cc: Matthias Brugger , Jason-ch Chen , Johnson Wang , Singo Chang , Nancy Lin , Shawn Sung , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230709162641.6405-1-jason-jh.lin@mediatek.com> <20230709162641.6405-3-jason-jh.lin@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230709162641.6405-3-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 09/07/23 18:26, Jason-JH.Lin ha scritto: > OVL layer should not be enabled before crtc is enabled. > The plane_state of drm_atomic_state is not sync to > the plane_state stored in mtk_crtc during crtc enabling, > so just set all planes to disabled. > Please add the relevant Fixes tag and resend. Thanks, Angelo > Signed-off-by: Jason-JH.Lin > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index d40142842f85..51d10e65004e 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -410,6 +410,9 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc) > unsigned int local_layer; > > plane_state = to_mtk_plane_state(plane->state); > + > + /* should not enable layer before crtc enabled */ > + plane_state->pending.enable = false; > comp = mtk_drm_ddp_comp_for_plane(crtc, plane, &local_layer); > if (comp) > mtk_ddp_comp_layer_config(comp, local_layer,