From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5159B35C197 for ; Fri, 29 May 2026 15:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780068137; cv=none; b=KthVR2yRLaT/X2LxUAk5++HMQU0+qve9NdRvBcUoHDFffbPDbtcURi+3sySukGpNoDOcfjZueDXcY9cPC1zmXc6no2soyZhSlJi3syokHxOQaNN7ZZmuxsnnGUnOvdmuFW2iD6XxXhgUzBbdDRi4DZesYBwNN85vBSJPBt6/uxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780068137; c=relaxed/simple; bh=yI1iGkmiSzMFJtnw1lJVP5u1P/QKkpQHXLglYhfy84A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bhpqDpNfl2lva4f1xO6tHc/1E6M0uQc7/3u+xVnSRDG3Vkvr4CDGot3KO4yGq+0iLEbY/M2ZWkfD1C9jPyzpduf06KoLplvsuv05io04hECcf2F+wSLlL2hKX7Su9vBg69gMeBrEJpEcm3HRj30PWMtt2vLMOWvZ5v9YsYT9h20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bun+YZLm; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ErFML1Dp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bun+YZLm"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ErFML1Dp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780068135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=315e7bSessxyz662R8s4IU7FTBDlj+mVbEZvVNtQrTU=; b=bun+YZLmH1ZBFsj6W0Rmk1LgtrZA2lLTD/L8h2mMfHXTxHL1BXK9xRhtXMQsUOzNUoW5/n ShQOWKDAkQelFsFz0R9E4jIEo+sOs27xWXJl+3z7ccU821qBqTm2RGm8Q2gOOjQslbbi7I bM4Pp9dTjy+zIAg1gae/q3JdWwrcc7c= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-kSo6d3MhPkOXNmdE6zXpRA-1; Fri, 29 May 2026 11:22:14 -0400 X-MC-Unique: kSo6d3MhPkOXNmdE6zXpRA-1 X-Mimecast-MFC-AGG-ID: kSo6d3MhPkOXNmdE6zXpRA_1780068133 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48fd3dbd16aso115314155e9.0 for ; Fri, 29 May 2026 08:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780068133; x=1780672933; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=315e7bSessxyz662R8s4IU7FTBDlj+mVbEZvVNtQrTU=; b=ErFML1DpHf3HqbIEY2F4v7/pz6xnERf0I7Wf+f30so2xHb7rz1FRJBRNsUzLNXnFzA 1LiMKQsj01bouizfzF4m6kySSezMkgzxJMEt6AAZ5QcUyvKGpNwnnyrPHVFojuPKcdD5 NysE5pbo0LjWJHu2elVVrZlb7jSUU1DZy/g72ladWLcoPd4fsl4YE1mUj/O59vvWBTNP V3aNmdCPVNorXEs9H8tU1sJhucLRaIay+4LXT4poSqzk9nQluIg8Nks441Z6Hi7YmPwV etkZQlhLvf3ano+DFq7DX2IVNsmYTa+6IaFSoCO7H93eriEo4KFXjI3/BU05246wN4s3 KMGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780068133; x=1780672933; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=315e7bSessxyz662R8s4IU7FTBDlj+mVbEZvVNtQrTU=; b=kw1sT9KIgqBqV/Z0yC7kwutut70fcrfPXhsGnaoKi1hFEWdzN9GL4DvRzMI1jw7PVF lHYV6i+PbBVISqxGltXBvYR+LNC6yniuDyYo0McU5BUacvUCBSI24k5TaUGC4xAbHz8K Q+cOm6YM/snUvO/0BHChbU3dyEuykvmMJsLdburw+/WyGtDJ+cfApdWPKFJXpyqwbXsR R+3Yj8PsvQWFiPDEpCVUr5n06YuiHJyhA24TFzeF7S8W7Bp1AgKQGIgXwiF0TRpRfirE t2M7JL4iqdw9XEZ2QKL5DBPVuts2TlyrYJoTaYhTl1Xo5cixKV4W9XJXFmJGlSAGEE/S 4UjQ== X-Gm-Message-State: AOJu0YxsDWiS0BrWWboBQTWsegoxUMDw0vjX8OZ32sjxDb0axSDw7D36 MesxjRPRYJ/vFFF5HWJlEFFzQkasd58N4r93nEm/+//eO3BvtZYQizknW4yHxAkXZgDrHQqr8pk MlDjnw1B3KQwdCHQeUUIUER2OIPpJYE/lps9imMcsKz8qQrnPijJaVo+XwDEODI+gz6SyCsB8zW 35qR7WwQGGqOTVlDnq6Pm1Gi725LcGTGi1q2SrN//HL/g= X-Gm-Gg: Acq92OGC97zmH+45w1cce4gpmFS/+x2eK2Wyr/ZPKI05jBo1sNkDJDRTq0kHmZ11yxz SjsjBIYNdmywzVayAhHzEC8UwHTlCesWGJQBWbUKTPjAWKzkodDHA89o2V/Q32uPAhd4DP+RLv/ MlTxCHsYt8lmcbhHnho3CVvc6qyByIfxDP/apiZkeIDkgiqsSYXuyPJLylg0QLhkTLBtFPFmbxe Cwk3b36R8cVGpsj4zEM4EwagWDxAno15JzG4oemI+jycptCrr7BwYeKZ+Gn6/EN7DMw4SdiPL7G cLyyoVseot7rT+k303gsb+nLEEgocTaSFdeVNi6i62Tt5PHaFscwbuvHE2Mziv7HV+NbzIym/fB JgGLAEEuWRsbE4OutCTOa1epJFsVhgkRZKelnXHZas0KhaHuqUe1AEA== X-Received: by 2002:a05:600c:8b12:b0:490:2238:4021 with SMTP id 5b1f17b1804b1-490a29079a0mr2313485e9.8.1780068132933; Fri, 29 May 2026 08:22:12 -0700 (PDT) X-Received: by 2002:a05:600c:8b12:b0:490:2238:4021 with SMTP id 5b1f17b1804b1-490a29079a0mr2311035e9.8.1780068130983; Fri, 29 May 2026 08:22:10 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-45.inter.net.il. [80.230.25.45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34b47eesm4805302f8f.9.2026.05.29.08.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 08:22:10 -0700 (PDT) Date: Fri, 29 May 2026 11:22:05 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v9 01/37] mm: mempolicy: fix interleave index calculation Message-ID: <56ada5b2073a7e307e03fcb3f5327d0cf3dbeb8a.1780067977.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent The NUMA interleave index was computed as two separate terms: *ilx += vma->vm_pgoff >> order; *ilx += (addr - vma->vm_start) >> (PAGE_SHIFT + order); This has two problems: 1. When vm_start is not aligned to the folio size, the subtraction before the shift lets low bits affect the result via borrows. 2. For file-backed VMAs, shifting vm_pgoff and the VMA offset independently loses carries between them, giving wrong chunk indices when vm_pgoff is not aligned to order. Combine into a single expression that adds vm_pgoff and the page-granularity VMA offset first, then shifts once: *ilx += (vma->vm_pgoff + (addr >> PAGE_SHIFT) - (vma->vm_start >> PAGE_SHIFT)) >> order; For anonymous VMAs, vm_pgoff equals vm_start >> PAGE_SHIFT, so the vm_pgoff and vm_start terms cancel and the result reduces to addr >> (PAGE_SHIFT + order), same as before. For file-backed VMAs, the sum vm_pgoff + (addr >> PAGE_SHIFT) - (vm_start >> PAGE_SHIFT) gives the file page offset of addr. Shifting by order gives the correct file chunk index. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 Reviewed-by: Gregory Price --- mm/mempolicy.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 4e4421b22b59..d139b074a599 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -2048,8 +2048,9 @@ struct mempolicy *get_vma_policy(struct vm_area_struct *vma, pol = get_task_policy(current); if (pol->mode == MPOL_INTERLEAVE || pol->mode == MPOL_WEIGHTED_INTERLEAVE) { - *ilx += vma->vm_pgoff >> order; - *ilx += (addr - vma->vm_start) >> (PAGE_SHIFT + order); + *ilx += (vma->vm_pgoff + + (addr >> PAGE_SHIFT) - + (vma->vm_start >> PAGE_SHIFT)) >> order; } return pol; } -- MST