From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE81AC432BE for ; Mon, 16 Aug 2021 17:17:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C91E160E78 for ; Mon, 16 Aug 2021 17:17:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231183AbhHPRS3 (ORCPT ); Mon, 16 Aug 2021 13:18:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:35608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbhHPRS2 (ORCPT ); Mon, 16 Aug 2021 13:18:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6BD2D6054E; Mon, 16 Aug 2021 17:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629134276; bh=IBjQ2hhW6a6ZbDmFSNRMf689ze6D1w9iG/hdqVz0zw0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=uahEmHkI86CByX/PbR+s4wRzyLPZOA+WtfdbH/wL9aSwRB/KwyPTRWnbB/Ee7j1Ap rxpEwLiF7rkeB1TqErTXEyKaOOpPVeiJy+C38BIOmPqKQfw9Sb9c2zP+eHXYYApRIZ EkUXeG+Lq44gPRkM5K0HVGKHuSNjHXA85e73oxzfopVFEZM1mnWj1JGCHOwAGIiU6M 08JvjPMg+eJ2BgrOUeyDDHBnaIIBQ0ax2AZH33m8U3E6s0qSGCNb5qjr1BkFGcL9cL /khAISWphgOj7qGoZ2Mq0xQ7BlJghyBkrnhmpBCZ6IBPlV5Xb07jKu+FQtZFhTePvs XtmjzNqbOGEPg== Subject: Re: [PATCH 5.13 046/151] interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Mike Tipton , Sasha Levin References: <20210816125444.082226187@linuxfoundation.org> <20210816125445.588155407@linuxfoundation.org> From: Georgi Djakov Message-ID: <56b19dc0-b5b0-accb-956d-1a817444ca04@kernel.org> Date: Mon, 16 Aug 2021 20:17:52 +0300 MIME-Version: 1.0 In-Reply-To: <20210816125445.588155407@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.08.21 16:01, Greg Kroah-Hartman wrote: > From: Mike Tipton > > [ Upstream commit f84f5b6f72e68bbaeb850b58ac167e4a3a47532a ] > > We're only adding BCMs to the commit list in aggregate(), but there are > cases where pre_aggregate() is called without subsequently calling > aggregate(). In particular, in icc_sync_state() when a node with initial > BW has zero requests. Since BCMs aren't added to the commit list in > these cases, we don't actually send the zero BW request to HW. So the > resources remain on unnecessarily. > > Add BCMs to the commit list in pre_aggregate() instead, which is always > called even when there are no requests. > > Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh support") > Signed-off-by: Mike Tipton > Link: https://lore.kernel.org/r/20210721175432.2119-5-mdtipton@codeaurora.org > Signed-off-by: Georgi Djakov > Signed-off-by: Sasha Levin Hello Greg and Sasha, Please drop this patch from both 5.10 and 5.13 stable queues. It's causing issues on some platforms and we are reverting in. Revert is in linux-next already. Thanks, Georgi