From: Alexander Graf <agraf@suse.de>
To: "Yan, Zheng" <zyan@redhat.com>
Cc: ceph-devel <ceph-devel@vger.kernel.org>,
Sage Weil <sage@redhat.com>, Ilya Dryomov <idryomov@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jan.Fajerski@suse.com, Jeff Layton <jlayton@redhat.com>
Subject: Re: [PATCH v2] ceph: Fix file open flags on ppc64
Date: Fri, 28 Apr 2017 11:14:56 +0200 [thread overview]
Message-ID: <56b605cc-ee88-612e-4935-a60a3a151f04@suse.de> (raw)
In-Reply-To: <D29AEA6E-CB75-42CF-A0B6-47F61A23183C@redhat.com>
On 28.04.17 09:57, Yan, Zheng wrote:
>
>> On 28 Apr 2017, at 00:34, Alexander Graf <agraf@suse.de> wrote:
>>
>> The file open flags (O_foo) are platform specific and should never go
>> out to an interface that is not local to the system.
>>
>> Unfortunately these flags have leaked out onto the wire in the cephfs
>> implementation. That lead to bogus flags getting transmitted on ppc64.
>>
>> This patch converts the kernel view of flags to the ceph view of file
>> open flags.
>>
>> Fixes: 124e68e74 ("ceph: file operations")
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>
>> —
>
> I removed the "unused open flags” dout and applied the patch. Thank you for tracking down and fixing the bug.
I actually put that in on purpose, in case anyone in 2 years tries to
find out why a particular flag doesn't get populated :).
Alex
next prev parent reply other threads:[~2017-04-28 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 16:34 Alexander Graf
2017-04-28 7:57 ` Yan, Zheng
2017-04-28 9:14 ` Alexander Graf [this message]
2017-04-28 9:23 ` Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56b605cc-ee88-612e-4935-a60a3a151f04@suse.de \
--to=agraf@suse.de \
--cc=Jan.Fajerski@suse.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®