From: Michael Walle <michael@walle.cc>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: tkuw584924@gmail.com, takahiro.kuwano@infineon.com,
pratyush@kernel.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, bacem.daassi@infineon.com,
miquel.raynal@bootlin.com, richard@nod.at,
Tudor Ambarus <tudor.ambarus@linaro.org>
Subject: Re: [PATCH] mtd: spi-nor: let SFDP determine the flash and sector size
Date: Sat, 22 Jul 2023 14:56:20 +0200 [thread overview]
Message-ID: <56b679ea1b2424a55a8dc390ba23e7af@walle.cc> (raw)
In-Reply-To: <20230722045901.9872-1-tudor.ambarus@linaro.org>
Am 2023-07-22 06:59, schrieb Tudor Ambarus:
> sector_size is used to determine the flash size and the erase size in
> case of uniform erase. n_sectors is used to determine the flash_size.
> But the flash size and the erase sizes are determined when parsing
> SFDP,
> let SFDP determine them.
Great! I have a similar patch in my preparation for the flash info
cleanup, but for all the flashes.
The flash size is overwritten if PARSE_SFDP is set anyway. So
that's fine. The sector_size is used for the erase ops and the BP
locking. The erase ops should be initialized with the BFPT, too.
So whats left is the BP locking, which is just used for gd25q256.
For now we'd need to leave the sector_size there.
Would you also drop the size and sector size for all other
PARSE_SFDP flashes?
In any case:
Reviewed-by: Michael Walle <michael@walle.cc>
-michael
prev parent reply other threads:[~2023-07-22 12:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 4:59 Tudor Ambarus
2023-07-22 5:14 ` Tudor Ambarus
2023-07-22 12:56 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56b679ea1b2424a55a8dc390ba23e7af@walle.cc \
--to=michael@walle.cc \
--cc=bacem.daassi@infineon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=takahiro.kuwano@infineon.com \
--cc=tkuw584924@gmail.com \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®