From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
marex@denx.de
Subject: Re: [PATCH v3 3/3] dt-bindings: clock: imx8mp: Remove unused IMX8MP_CLK_AUDIO_ROOT
Date: Thu, 27 Oct 2022 22:26:00 -0400 [thread overview]
Message-ID: <56bc1673-25ab-832c-ea2d-56c1ade61221@linaro.org> (raw)
In-Reply-To: <CAA+D8AMTY=733JZujLrE2aG43=o-9JCg7VfOOq67rnxXKdn6PQ@mail.gmail.com>
On 27/10/2022 22:20, Shengjiu Wang wrote:
> On Fri, Oct 28, 2022 at 10:17 AM Krzysztof Kozlowski <
> krzysztof.kozlowski@linaro.org> wrote:
>
>> On 27/10/2022 21:53, Shengjiu Wang wrote:
>>> Remove unused IMX8MP_CLK_AUDIO_ROOT which is replaced by
>>> IMX8MP_CLK_AUDIO_AHB_ROOT.
>>
>> You break users, so this should be a bit better explained.
>>
>> I do a search, but no one is using it...
The commit msg should explain the reason and it didn't. Also a reason
like "I did not find in Linux upstream a user" might not be enough. What
about U-boot? BSD? Other firmwares?
Best regards,
Krzysztof
prev parent reply other threads:[~2022-10-28 2:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 1:53 [PATCH v3 0/3] clk: imx8mp: Add audio shared gate Shengjiu Wang
2022-10-28 1:53 ` [PATCH v3 1/3] dt-bindings: clock: imx8mp: Add ids for the " Shengjiu Wang
2022-10-28 1:53 ` [PATCH v3 2/3] clk: imx8mp: Add " Shengjiu Wang
2022-10-28 1:53 ` [PATCH v3 3/3] dt-bindings: clock: imx8mp: Remove unused IMX8MP_CLK_AUDIO_ROOT Shengjiu Wang
2022-10-28 2:17 ` Krzysztof Kozlowski
[not found] ` <CAA+D8AMTY=733JZujLrE2aG43=o-9JCg7VfOOq67rnxXKdn6PQ@mail.gmail.com>
2022-10-28 2:26 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56bc1673-25ab-832c-ea2d-56c1ade61221@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abelvesa@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®