From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3514732B134 for ; Thu, 9 Jul 2026 13:57:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783605423; cv=none; b=EfXhKqYpy3Ln4tT+qlEBWWplCwiqmbkfvR+148FJY+U2UAvn3IxddqaYEgbU3qmCO2M4EXHG6XR4Zwjo5ATG8gvBXySjTWeCvvPeEMxAVl7RLbk5IS4sXcg9RXJ2GF+Afhol1tQ4hCaXyfqcmPp7dv0uwnIX3HageR4MA6C5uMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783605423; c=relaxed/simple; bh=K5fH2IKrnfPEIkySIrvu/rBHR4F+hmoycCCFpOEaZ0g=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=ObIbLWfxtjevSZ4wArIfZrr+eQF6r96esGGKK0ufOY2vVk8iUVzTrITyL3iURj1Qc07LeIq/roSv5CFxvuVZAMypqji/IKkE+6GZxamPtt7wDuQ2ypF4H9gLWZ2giG/A6d2fyKD/DV+vIfR9vCbfT1XiobGKknBl+9Q1JKcw++0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MYtfZzOk; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LIaDsQXP; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MYtfZzOk"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LIaDsQXP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783605421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cANH06pZ/zI+QIWpTjNeANK2N/N1qkbVAiixYLvi4Ts=; b=MYtfZzOkVPZDixB2S9vMbbcxXAf8wGob04ZlnAey9cHY+UapIcNvLFkTYhBK/5jFHj6o1u qKKKwyyT0v1YiqypCEdUIrtKapO8YsPh3ooy2uVKiqx+CnOV4k1qekHbnfvPrK7GChFrGE y6c68p0q0xhnM67qD+MeXlnzcIDo9ek= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-532-Qx_uS5BDNUKuI53ppyhFqw-1; Thu, 09 Jul 2026 09:57:00 -0400 X-MC-Unique: Qx_uS5BDNUKuI53ppyhFqw-1 X-Mimecast-MFC-AGG-ID: Qx_uS5BDNUKuI53ppyhFqw_1783605419 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-476608a9fefso734126f8f.1 for ; Thu, 09 Jul 2026 06:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783605419; x=1784210219; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cANH06pZ/zI+QIWpTjNeANK2N/N1qkbVAiixYLvi4Ts=; b=LIaDsQXP2mW71crkWDv+NCPeMxIZzukCABVBiLyxuH/HVFB/AFlEajvYElBZS623CN m0iK3Yu4EzajQaKxm4lH+AhCeo7LgQzhlgsdRz6r0/tSY8irsg9Noh1egyeUpOgvNdWf EMnmjv0TjUc9bWVupzdZyCu/nXvlNlnZHEKL2OIS7H96WBQ6h6e5WE3+RPjm4o9Ywy0C /w+kVIA8ZFubt2aCAMYRT5IX0Qgx2kfJg1MAJhTGkPcQwKCCLKPLg0Jq+Azq+5js6E58 1WsTEn9cf8UQoEsN5FmIkyAWuwbQfwvrcPazSN15uaMIv2GwgPVDqx0zMQEdnWqGRV8S yfiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783605419; x=1784210219; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cANH06pZ/zI+QIWpTjNeANK2N/N1qkbVAiixYLvi4Ts=; b=B5LuobT2s+8UqgsWV59w0uDfKN48FSD+fWhZNpquOF+dTlP91rxFAkzL2Axod2ajpG SlOLlw5UsiuIBpugKofNnVp5qGEVIw00MeNcbCDtt4YVfKkSg+CWjUMbtAKQTujQF3mh BrnQw3u6EILK0hyj6R9OSqJ0hmytAwHp7IXKFWwCvIaZM0RNhhuHhl1e+vAHzAedfNne BQ4eiE068SyaVvhBuqUhr4WBI90IYVF3+lqzc4PI2/5isXkccPqsdyO8FkfmZmTN/tWx oXOQwpV1YDfPBfcWuvPnIaa30g6KrN7FwoyOWm9mctZJu+iVDjPQqKet1G2QpbSn+mCg zO7Q== X-Forwarded-Encrypted: i=1; AHgh+RpG0WfvhZmm5Pqf5mF45pVLE+P5ObIGdto4AbpI5v8DsDKCaIH1tVpke5iERaTiAwQY6s4w6owXCwL/tW0=@vger.kernel.org X-Gm-Message-State: AOJu0YzU6/EUSff9O2i7ZjwkcK0jYndrUI982GE6PmMlM71G9vtB91hS U2TMQXwtiVwRV0YJnAdrCJfp8G3UVMsGtPNjpr2SC5YESmGfJPpOcQ8XLycHYQTcjOS8Skm/6+B KxxFif6v6Jd0ezOx+L1BbSUqhmn4TGSaBBOFIwnPmmmrdWnvVxZ4peVvGtbe/F6FWJA== X-Gm-Gg: AfdE7clC6Sk+nCqcB6EOUH7/zXcaPhy3yyn0VjQrChtYcvUxhNwBq/oyH5RBWqiK/lo ljJNHOK7UEcG6spFvxlnLxpKeFdZH/PAhxseLnCmy7YodCl29lUTe3wX6gg7saGxYWZ2dymcEPi 1Vi8B9CovvXskK4JNjXb/t6v4hELMx0CvKC3beNvoO5Ll4Qz8ZL8zuFsQ+laDY5k0cSTL/PkOZf VvsjhUfPy7hbmGDOs2VxYXUu2mCmFWYNhOYr2LcYbA1mdcrFmzY++9bHNR9eiXVK/faz4U0EW8C UK9NZtHsirnwcD2jJNQaHrDzDd7jc3IPrAHnaggVgWprjXs92J1/vf7izbulFyEtG1NxXWC1gJK g4qdz2YzBB5Yvj4mYzLELx/Laorf7exmJRsFat3TtvvevKIEFnae8/cIuEl1Jb+e98mrf4REzft hGyZUGmlWiKdoQ X-Received: by 2002:a05:6000:4711:b0:474:c3a5:4132 with SMTP id ffacd0b85a97d-47df754a4admr3518322f8f.9.1783605418674; Thu, 09 Jul 2026 06:56:58 -0700 (PDT) X-Received: by 2002:a05:6000:4711:b0:474:c3a5:4132 with SMTP id ffacd0b85a97d-47df754a4admr3518275f8f.9.1783605418184; Thu, 09 Jul 2026 06:56:58 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa09608d4sm53167952f8f.25.2026.07.09.06.56.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 06:56:57 -0700 (PDT) Message-ID: <56be707f-3f3e-4e5f-8379-3305c864c9d4@redhat.com> Date: Thu, 9 Jul 2026 15:56:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/4] net: usb: centralize usbnet_cdc_zte_rx_fixup in usbnet To: Oliver Neukum , Manuel Ebner , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, shaoxul@foxmail.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260702143142.890654-1-oneukum@suse.com> <20260702143142.890654-3-oneukum@suse.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/6/26 2:00 PM, Oliver Neukum wrote: > On 02.07.26 20:19, Manuel Ebner wrote: >> On Thu, 2026-07-02 at 16:25 +0200, Oliver Neukum wrote: > >>> >>> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c >>> index 5544af1f4aa5..7beea6d0e731 100644 >>> --- a/drivers/net/usb/usbnet.c >>> +++ b/drivers/net/usb/usbnet.c >>> @@ -2347,6 +2347,25 @@ void usbnet_cdc_status(struct usbnet *dev, struct urb *urb) >>>   } >>>  } >>>  EXPORT_SYMBOL_GPL(usbnet_cdc_status); >>> + >>> +/* Make sure packets have correct destination MAC address >> /* >> * Make sure packets have the correct destination MAC address > > This sort of puts me into a conundrum. Does networking code use > the short style of comments or not? The documentation says that it does. > I am fine either way, but I need a clear rule. Networking code used to require /* for * multiline comments */ but somewhat recently we switched to accept also the more common /* * multiline comment */ Checkpatch accepts both; it's not a deal breaker either ways. /P