From: Dave Hansen <dave.hansen@intel.com>
To: Andy Lutomirski <luto@kernel.org>, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
Rik van Riel <riel@redhat.com>, Nadav Amit <namit@vmware.com>,
Michal Hocko <mhocko@suse.com>,
Sasha Levin <sasha.levin@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 2/3] x86/mm: Make flush_tlb_mm_range() more predictable
Date: Fri, 21 Apr 2017 11:54:06 -0700 [thread overview]
Message-ID: <56bf2b62-ecae-65ab-0ade-3c659bfd640c@intel.com> (raw)
In-Reply-To: <438f3c3cd04ff7f2da482626d78ec0fd1f35385b.1492798187.git.luto@kernel.org>
On 04/21/2017 11:15 AM, Andy Lutomirski wrote:
> I'm about to rewrite the function almost completely, but first I
> want to get a functional change out of the way. Currently, if
> flush_tlb_mm_range() does not flush the local TLB at all, it will
> never do individual page flushes on remote CPUs. This seems to be
> an accident, and preserving it will be awkward. Let's change it
> first so that any regressions in the rewrite will be easier to
> bisect and so that the rewrite can attempt to change no visible
> behavior at all.
>
> The fix is simple: we can simply avoid short-circuiting the
> calculation of base_pages_to_flush.
This looks sane to me. I think it makes things more straightforward.
Acked-by: Dave Hansen <dave.hansen@intel.com>
next prev parent reply other threads:[~2017-04-21 18:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 18:15 [PATCH v2 0/3] x86/mm: Straightforward TLB flush fixes/cleanups Andy Lutomirski
2017-04-21 18:15 ` [PATCH v2 1/3] x86/mm: Remove flush_tlb() and flush_tlb_current_task() Andy Lutomirski
2017-04-21 21:59 ` Andy Lutomirski
2017-04-21 18:15 ` [PATCH v2 2/3] x86/mm: Make flush_tlb_mm_range() more predictable Andy Lutomirski
2017-04-21 18:54 ` Dave Hansen [this message]
2017-04-21 18:15 ` [PATCH v2 3/3] x86/mm: Fix flush_tlb_page() on Xen Andy Lutomirski
2017-04-21 18:46 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56bf2b62-ecae-65ab-0ade-3c659bfd640c@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhocko@suse.com \
--cc=namit@vmware.com \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome