From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012066.outbound.protection.outlook.com [52.101.43.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C31BCA4E for ; Tue, 9 Jun 2026 06:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.66 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780986552; cv=fail; b=I4M8PlSMbfOjtnoXm0BB1s0hncA98De158kLwwHCK2oSiFjkj1k1mJTpXHbXt2LizSFAI+KiwkGNZ0LErTQM6ixoOrvfM9+9XVJ60B8Gj8BP+/plM7R4y0GdT31iYAxJFFeH7OcdfqVyBbXANAJQpKz5cgowSSCj7TxRQrW8l+g= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780986552; c=relaxed/simple; bh=SQaMGDFxwnSM2cyezczOYUYRWcx5vSrmcTDlJFcy4yo=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=AR0ZEjcWOU5zQ1pJDAU1Bl30kMs/Etb2cazAC0Bz17ObEjd5HfSNIgzkvvomGm0LVoT2idGY/+qQF2kqBQgoQ773mCEG9bfp570jXsOTowva50sDopKbgfYC8Jvp3O+dFG5/zU2uhIcgkgCoJzAXjbpDFl9SzLgVw9cVUts7u38= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=f+jfn1Il; arc=fail smtp.client-ip=52.101.43.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="f+jfn1Il" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BjQP+lbqs+3NmKL2ifye2+pRq2HDqBGEk/VGEtz1L5u+7iJZweTmk8cHh2QmcCa8+EMPpytOFtPPmMyt/mE/txx3xUqMDcRBCCV4yZBIIyUZXa1wB2/RCkwvycp9nS9th1rehICqmIsGAb71KmqpMyhuuSoxTr4H0y3s5/FZQKqs7GbwjESidDN4S0//CBcbYBJDC1VqH+anByjVxKfDQuUEjIEEPxMzOJPC2/qHyAbXXKDoXflHJ3i2TbBdlEm8B/c062Hf+voVdjNiElS0jJzvyLQZUqn0zVBBPAHeN2zIyD5y8gp7/MrQ7TuhVbFjcwUmNPdc/3WCrJxlSpQNsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HZRz/P7QVrhHpzREKXleSccXMkq3DYbK518ZyWN2DMw=; b=UX7g78XmpXYgUMRDseW0/5yR81mVMCQ0d14smpvXM/j8sgUwTX9Tmi+TMiMV8N+t+WDGGMgoxhMh8W7/spG1mu5Fau5uDu+4wSy7Muplt45LG8qsWG4/UX9FYaPwh/JeW7aZIHIWEMN2SKUyEy9fXVh6t1iH+jFawMBF08pl2FY1IigMf/0TwI/sGmjpEMkvSTE0hRJb6J5IPAmFVzz+Kteta70ygz7iYMAdpMIazIR5r3qbe/ebeBvdUfE92XyGpKPQ7tGtbxmwtP/OUY1qyQNkGpNEQfYNKrVgb/uzUVWT6J307ojKgPx4K6gAVo3Hi694YK7EvV/2dgrBCd/F5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HZRz/P7QVrhHpzREKXleSccXMkq3DYbK518ZyWN2DMw=; b=f+jfn1IlguIomoSBUS29b1QMDHIw6Dsla3qh//xJ2QUPfTgxzGHpBVhnXASV0JLlnqI5vfDkWiXlLF8/Xsc0XHZhbFJI8fRwIpRq5fZLTw5sv4328grllv3+gnzSlArgXR0GtPnvvEa9mtpV33wUhDWDfGqVlDdoon3CiMe5ntw= Received: from DS7P220CA0017.NAMP220.PROD.OUTLOOK.COM (2603:10b6:8:223::11) by DS0PR12MB7899.namprd12.prod.outlook.com (2603:10b6:8:149::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.11; Tue, 9 Jun 2026 06:29:06 +0000 Received: from SA2PEPF000015CD.namprd03.prod.outlook.com (2603:10b6:8:223:cafe::1a) by DS7P220CA0017.outlook.office365.com (2603:10b6:8:223::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.113.10 via Frontend Transport; Tue, 9 Jun 2026 06:29:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SA2PEPF000015CD.mail.protection.outlook.com (10.167.241.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.7 via Frontend Transport; Tue, 9 Jun 2026 06:29:06 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Tue, 9 Jun 2026 01:29:05 -0500 Received: from [10.136.43.95] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Tue, 9 Jun 2026 01:29:00 -0500 Message-ID: <56c534bb-a96d-45f7-ac31-1a5234271ba8@amd.com> Date: Tue, 9 Jun 2026 11:59:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/6] sched/fair: Do not skip CPUs of similar capacity with busy SMT siblings To: "Chen, Yu C" , Ricardo Neri CC: "Rafael J. Wysocki" , Ingo Molnar , Peter Zijlstra , Andrea Righi , Len Brown , , , Juri Lelli , Steven Rostedt , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Tim C Chen , Valentin Schneider , Christian Loehle , Barry Song References: <20260608-rneri-fix-cas-clusters-v4-0-1526711c944c@linux.intel.com> <20260608-rneri-fix-cas-clusters-v4-1-1526711c944c@linux.intel.com> <1ee48251-8f70-4632-bb4b-79760c1c8a8b@amd.com> <32d47573-75fd-4a8f-aefb-ce7fb1136346@intel.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <32d47573-75fd-4a8f-aefb-ce7fb1136346@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015CD:EE_|DS0PR12MB7899:EE_ X-MS-Office365-Filtering-Correlation-Id: e3b836b7-17f0-412f-e886-08dec5f0681b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|1800799024|82310400026|7416014|376014|11063799006|4143699003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 9G85J2NSSEKJi5ENaK0Yg0ySaURQ7V71KipziVFKC6wGcpP0ruDSJXk2SMSXUy6+8KYqZZi7NBPykryNDmb5hG/0X/iTYFcLSAVZ592KQyIJtKFsdKjQVO/DVTkykCG8bKQ182dEBEy0f1W/Z15FELk+uhGBZdfPQ1CZTvyjy+KwyysaFYcyKsudupCo29SA3J1KgE0mwk/Ib4nZQ5ScHz7aZ0pksJNdlFSDSr09C4SsXwP3QWujQndov7BLDX3arZ1w2PRDepM6ZBaDjCfe55SdihbUgWM/C99X45ucS9v7FwasEBUL0JsyVIbt0dtnyNxy7DQ6VZ7Mal2Yk6efg3Zoeh/K6eXuStjUhGhmtkY1NxX94+vpdZhoFe7XzMXKO5osdtT5/p6ygrwP5wjMzP+AryTBqXBB7xDtZexLR78uz4j5MNDhetHoWCHyJOelIc6floeCYC+rkzl7Z5w1kFQ+Z4IK9p5ObS/Rc1UwHDk/vTmvFt4u5eJDAsOARI6zl1qBv/WDPmW2z1PWtsLNfYxeZEASqtx0ADDsqOVYSNeEVwRT0YMSgm972cbdkF+wz4CvBOcpXDW86e65ar1ZGED8aD+ldK9cg9aA0M0PRDpLmDYlhT2zfVCwZ1pcKqJ0TuOCowN5yNCLjFqS61Ea4F9jqGj5aMeweCZ0Pk3Gpp/Vs1dDVpxiDrTxeHMPvJHJaSKC9jM3dt8rG0EskbggkXtfKtHeJd+iVCwi//6jekU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(1800799024)(82310400026)(7416014)(376014)(11063799006)(4143699003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uAECmOGYIqYsdEnLBKzumI7Ta6m/9A4NLUQnEzwNdZywD3mcTJOA9nT5va4rRyE3WDZFos2nMtKm292eoTxpNZOjWgNPTBLwEn9DAhR/YPEcs1QBpC6uDYOWJUzGH0suH9zHZeTQMYB7OLkxWNAmm8MQY5FZrbo02EkCDY3BASV/vKYGzmE76xebIAqUowW4HU6lZXAVjEeEFGWVXgW5nUhTBIFGi9fAX1JMIXyzROgYRsL346ewHvcTv55dAXR+55FQvvkIpthwJLYgWz9W7sTeNxoRUjvDboqvg0PGgVCJJBYOiM+k7G1p386dXfnXZauC3uWbnpO3x7UTZV3ePWPD38kHwfjWGyV5/+8cXrR+2qj6hj+T47tGNZDk0cfBqdaPAhkcSavo0o95gbzWSupuo+FCDKxaPGdcc3bXUD7NykaQTDZ69pojxgFvnpcc X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2026 06:29:06.2031 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e3b836b7-17f0-412f-e886-08dec5f0681b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015CD.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7899 Hello Chenyu, On 6/9/2026 11:54 AM, Chen, Yu C wrote: >>> @@ -12964,8 +12965,12 @@ static struct rq *sched_balance_find_src_rq(struct lb_env *env, >>>                   * eventually lead to active_balancing high->low capacity. >>>                   * Higher per-CPU capacity is considered better than balancing >>>                   * average load. >>> +                * >>> +                * Busy SMT siblings reduce the capacity of CPU i. Do not skip >>> +                * it in this case. >>>                   */ >>>                  if (env->sd->flags & SD_ASYM_CPUCAPACITY && >> >> ... >> >>      if (asym_balance) { >>          /* Busy SMT reduces capacity */ >>          if (sched_smt_active() && !is_core_idle(i)) >>              continue; > > We might not want to skip i if it has SMT busy siblings? > if ((!sched_smt_active() || is_core_idle(i)) && ... Ah yes! I forgot to do the ! of the condition :-) Thank you for the correction. -- Thanks and Regards, Prateek