From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD6DD26F2B9 for ; Tue, 13 Jan 2026 07:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768287614; cv=none; b=rrEdQtm/lK48VnZwPaRVtEyb2vcMUveiT5hn++rPga67daEiyIT0jyQmDbI3grFfsqJGc+zbCmN/0DG9XLIWrdNuT0iEF1gjbmXmEM/Hd3WkNMm6i/K5luA9v5s4+73+WfBKee3CKXzbXsOJV8AAwgc5xROhYpDkDACxG3G0l4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768287614; c=relaxed/simple; bh=IGkJdLUV0fzpoWdZ3Pzr7pe3ksxgaMVKHBAKNFlMm8E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BMkOMdevAq8hvHzeULyl+WC6x4XWId+AszeNcvoPG7LzBgLJbdOOEnrysQRm/Xfgz+xGmdzZZu6VlqWa8tdBgRRPxV63hF+rzBkZH2Fm5fshuAN4a15+FQJav7XrXxv/vXUjH29mzSToQ65bXiwKku83ub8whet00fhJRE0HhSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LOCmgVNy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CEuhB5IO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LOCmgVNy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CEuhB5IO" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60D5na4v3735206 for ; Tue, 13 Jan 2026 07:00:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AXkl1pxhWWfkg7abcGoMjqh2hI4gBsUgUfa7xAd1HCc=; b=LOCmgVNyotarnjRP LYg4ysktQETM8j5iRiFGPW4fXtRYbPB+BKNtwF98HanNfsZnkXYWyHXilJj7l3yG 50kcVtijaD36xh8V4F6WFav/U5zyByATVTtwsvULNUrbZvD5MGDMQlU6IIzcgcLm tNe6Xv/dcmNkiZIZulI9qvhVsBK3tL/CxIDiw5JWtU+Y8rV1MY9if1sNkZS233GL TfsE1zJKIIiRMHWKDWlEJsbBipVt2iCMR3O1lQbOm+VGbkiENOVBZdjSID2A2fv9 a13Xilrusvl4sKCUkUvyEPCfgaGjUf6Gl3qjASgBhwMjIZshoHfTZdwqdjr+4ygq 7BXf3A== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bng8785t9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 07:00:11 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c52779e9e65so2205678a12.0 for ; Mon, 12 Jan 2026 23:00:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768287611; x=1768892411; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AXkl1pxhWWfkg7abcGoMjqh2hI4gBsUgUfa7xAd1HCc=; b=CEuhB5IOx7yK40DF0n6bHuhseUMB40PWrkqa0dvdqdgyw4jAZQND5PIHJV7ijaG56S LYPajnHatwjATngw6kWy6DrSKRU9pcLIgBYYvl4OCwrOiuHZVnK+yjP+WjScs3j9e5hn qC+3rOTyfYTk23/gRXIKAMWrkKJQ8cOAdPvg3wbTeigoRvb7lw+vffcAaSPXxv+yc095 Mb4ltSFU0UKvSEXezaSU1L4vvX5sPjIlxRL14FmnoZr+QFBh5aBHifEPDzt/Byr9kfcM uXlmly2azugoNQbOo7anYGIp+8yX+EGzx0AkMhDwwrSSAP21hreb/Rxa20E3+JCPh0Pw Wdxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768287611; x=1768892411; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AXkl1pxhWWfkg7abcGoMjqh2hI4gBsUgUfa7xAd1HCc=; b=leF72YUlnW85KPJN3HQxlXN/z5pD9yFwAWwFhaaIAD7ULsjQGLkhRbWL/EdofhAK9S ujEo3cJRklYDajW6A6etmgk+nPKdF88et5i41ZacpaDU2XAxOiA8IKZ5+9ep1g4ezMJC QgVNkxt4xvoIZw4bKFbgV+Op6ZFEHbr/v7k1vff+sQxjerjvUPFwhfHBOPfHSYFdVUGp 4EboBzbTcSVRPB43LYSAuuCNLyQ7x+U3sM1wfUQp5Xt65Z11TVHCBAeFx57L42YAZBfh 1m6I4Ic8eZtArx35ycxLYRfkJsBdsqswyBTl02ZJhI17oJwAIh4swxQYB70hec+14FDk FuCg== X-Forwarded-Encrypted: i=1; AJvYcCXB0Jlr23xiIQ/HnyBO+QLpxJ4c/9JAHyDvjGaO732sqAjjRD68HFjyKoaul8TZePtIogZerMq+SI7qqQI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+c6kC0PwwIt6GEkaJL3r0jBRban+Kt917Xk59DlzlmwW89ZH7 lWGahxHceU3EN9eVrWV8KYQ/TyNejdGg/AB+shhDD06ay5Q/4OErnb9kBApqfyKyzbYxPW9UbQQ +XTdGHzDsxq5OZm7jFmSeQ7v0tBdavRA1v4N3TXx+6A/031XQbCe5RAQv2NxxOUJywsM= X-Gm-Gg: AY/fxX5695EkmumaQ9SHiSYlcE80RttqmkuRdeuRu9tNSXAngwmBLWuoGRNKNYcdRCp 5cct/BUQARWQRtLZAiTjc8DeeQpIyeRgTeQCKwjn9oSUVyZCgNrkXIccVr76oLFbkyFc409KxBD wdqTA3sTYx8c9LgLOjewYkS4Hj2NuOK+CzM+XyCtbD/IQ4WKGjNr/xHW3g8FKAwgk38Pwk/pDTB evMFKzEE9hzeYpT3zILDAx5WW5hVx0Ha+6xApJX1/2FDZpiqVqB39AOGPlSA0tVE6Bn+2Q51iuI wGSw1Z092xg894vWN0y6x47WlJWo3AM8oCM19vXwFKulvisLz2gdbgotO9vqnDoULcjnuYnvrT/ VlnFVTv5eZkslTV0ZKA+9KN1fWi0QXPyvxPL9+/W3ozHzxWIypK261iA= X-Received: by 2002:a17:903:1247:b0:29e:990f:26fc with SMTP id d9443c01a7336-2a3ee4e83bamr170127765ad.34.1768287610717; Mon, 12 Jan 2026 23:00:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IHoBvHv5GkG1uqzqiAt0OKhlGVz7jlfGMEmjPek3NHMbLzWn9trU/s+03Gg1FjnduZCdWlX+A== X-Received: by 2002:a17:903:1247:b0:29e:990f:26fc with SMTP id d9443c01a7336-2a3ee4e83bamr170127425ad.34.1768287610214; Mon, 12 Jan 2026 23:00:10 -0800 (PST) Received: from [10.152.204.0] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc8920sm190721945ad.85.2026.01.12.23.00.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 23:00:09 -0800 (PST) Message-ID: <56c6471b-c878-4afd-8e8e-d56266ca9c64@oss.qualcomm.com> Date: Tue, 13 Jan 2026 12:30:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] wifi: ath11k: move .max_tx_ring to struct ath11k_hw_hal_params To: Alexandru Gagniuc , jjohnson@kernel.org, ath11k@lists.infradead.org Cc: baochen.qiang@oss.qualcomm.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251228151408.2116108-1-mr.nuke.me@gmail.com> Content-Language: en-US From: Vasanthakumar Thiagarajan In-Reply-To: <20251228151408.2116108-1-mr.nuke.me@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDA1NiBTYWx0ZWRfX+2O4HB9A3JhY AA9Mp3tMZS9Vx1qOctr3mTi0dS3N1z1r4Lz0VbSZgKasMGzquXql5j+wEyWqDdkb/7n8T3CTBvT L+Co5oQ7E4nr1Eap+KRIfV0HR74gHxBhOV1rpJh0/Q+/z+qT366fIRhdiZ9SXX4iCPCAShpwat0 aowBfzkqu5PwpD7NQcskf8j+6lI6ZWUAu6LZz588xAqJLRZ++jmbB9NY7YMLWvuVPWNXL9lJuVO Ais5GHB6TPPuHBfeokwJ3dPbXmAux8j/EFwtNSkk53p+ZWUPvVG1p76kdXo5p3AABbe5ytBBy5v GOjoPyLmJclHcIUpL1wKIp8fkr7rS7oFQANn6ma+eOyk5EvLmk3gjGiuvjvLtDgwbxI9bagNdgh znf/C/gF/YnH0IjHmobrAcE71FcFWaFzUBlW2pZh1SbskCEaO5Eng1Eg7a/d9qaTdGCVFNlc++W IpypkQxzZFZkEYe9sjg== X-Proofpoint-ORIG-GUID: xyZKRe9Jv7zhlhXifEFHYXPbqDqtNx5Y X-Authority-Analysis: v=2.4 cv=IOEPywvG c=1 sm=1 tr=0 ts=6965ed7b cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=awC6CiPvetVZCStm32EA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-GUID: xyZKRe9Jv7zhlhXifEFHYXPbqDqtNx5Y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_01,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130056 On 12/28/2025 8:44 PM, Alexandru Gagniuc wrote: > ".max_tx_ring" is an upper bounds to indexing ".tcl2wbm_rbm_map". It > is initialized in, core.c, a different file than the array. This > spaghetti-like relation is fragile and not obvious. Accidentally > setting ".max_tx_ring" too high leads to a hard to track out-of- > bounds access and memory corruption. > > There is a small ambiguity on the meaning of "max_tx_ring": > - The highest ring, max=3 implies there are 4 rings (0, 1, 2, 3) > - The highest number to use for array indexing (there are 3 rings) > > Clarify this dependency by moving ".max_tx_ring" adjacent to the array > ".tcl2wbm_rbm_map", and name it "num_tx_rings". Use ARRAY_SIZE() > instead of #defines to initialize the length field. > > The ath11k_hw_hal_params_qca6390 uses fewer num_tx_rings than its map, > so use a constant to express the correct value. Add a static_assert() > to fail compilation if the constant is accidentally set too high. Text related to static_assert to be removed accordingly. > > The intent is to make the code easier to understand rather than fix > an existing bug. > > Signed-off-by: Alexandru Gagniuc With the above minor comment addressed. Reviewed-by: Vasanthakumar Thiagarajan