From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CC762E11DF for ; Thu, 3 Jul 2025 10:03:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751537031; cv=none; b=DndEGKAhjXxHF64Qr9nCpyB3F2Bn3yluxItpROZoEX3TaAF4BulNzYSvj/mqNEw2IIXreVJCkD34OxndfQLdf7cB3pJn+CFiPcl0Dbzr07Kh83pwLDF05NWhGdzPeLAgA7xO1+cdL+bgY4+nT4xWXE0jZjJoQHBqvnN3gUK7tJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751537031; c=relaxed/simple; bh=t2jpb7/Z5KgiLlt/9TEa+jgLsbUjBOFYGE/Oo12VC6Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WICITzS1RApOBp7FZUkTp2d+aRJK5tCC4tPRbUk42U+nXrlTKcbkAMmW5DYVIScpT1TWA5Y9X2/FI2hEHLZ7gSL54UQSnXZyraHQayXezgTlnzu91MoF/jXQQueYI2LRknu9F6CUDnUhONAkW4W0oLjDlogGxG/GKKyo4ssgtwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZSpfm78s; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZSpfm78s" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751537028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9B3ihYuWOeAFzcnls83zQtIbBYRAt2J+SrasgFV6Zjc=; b=ZSpfm78sb/acQ4XpbsIulma+mBERrQaA7p115HiYangNCCQTrx1BAx+ZcGqaXakP+2r+9D pLVQImcm5jBV5TbmKYxjomImeCjRhRecQTxgbJnRWRdlaiDa+IF45nTb+wgxYznje+i4Ex rkm+bri+tKbpHnIK96fwZPtFQa8BYYk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-IToMxI2FOJWFf1WTFhEnag-1; Thu, 03 Jul 2025 06:03:46 -0400 X-MC-Unique: IToMxI2FOJWFf1WTFhEnag-1 X-Mimecast-MFC-AGG-ID: IToMxI2FOJWFf1WTFhEnag_1751537024 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3b20f50da27so412718f8f.0 for ; Thu, 03 Jul 2025 03:03:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751537024; x=1752141824; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9B3ihYuWOeAFzcnls83zQtIbBYRAt2J+SrasgFV6Zjc=; b=rxSciMxE5PcO80NLBEhCywI2MsagtQcUaBfE6883di/kGjj+5xB8YrfBj46ppGgJcl sfFWdTmyzWOXK/2MGiZwNtARb4y4FQfld6772J+iedVbHqO6L/WaguxN1OYu0VW35wR1 Y/GkgTwoPCE6Vc3buVCZzJ8lfPaOgCc2cmHLeKfKa3ZYmRreTG/+joz8IJuNoBwH2D7F AHVjBEZSlNe2OflaMZZF/3rTXrjKkNJDeiMUaDV1SCLyygFfaJvJJjKHvnKkOL71K3PC XA/U3hBF2h69+AsMECH/f13brdXCCwYtSCv0ixegBw6NsGWG2/bEkpV5BIOUjSbWBxAD adug== X-Forwarded-Encrypted: i=1; AJvYcCW6YYBzcCz8KH/8wuxj0FHhhrPTOKz7jwnBWOLwi8fE06GeFAsqhOsK47u/UQzqaqDd2yjCMu7OFUixNr0=@vger.kernel.org X-Gm-Message-State: AOJu0YxBHEnubb63v75AreygscuUHvnMVrqekNT905oBEX1EPiDBUHof 4CrqfDaUJIUABaPvSyB+mONcy2teKqNTRJLVgvaLjfroSoKFYx8w4dOoKFGyJpGUeKKWj6nD4eV /W7VX90xTUFfLBXLsG1kkT8w2ggEb1sdUlUkWs51Bk0er6xXhUMnP40PALstqOmJxBQ== X-Gm-Gg: ASbGncsGAe8OdK7i+vA+Rd6uAb942+ko4/lT4NCH9JreoQhjy4e6BiXivb8z3JEKBEl 0fqSpnEwFCvRCa++NThKOMGdJ1tJYlDDMk7QRYBSgg+YCfAq5Sofykeil6cUlLRwJlAVLfH9Uwl mUwBJreEvlIhPuEt1wRZwdImf1YEgL49CdGPn4AD6v816Bj3wJ1zsFJegTXFDRLkExC1jzu7J54 NBauqg/PsGj7qUmeZucOMopdPf4nbbW4IqYnEY4KzvJLfcP39n9rIc3FkxQHqdJIp5aYgBrIoXz Nqf8Oc7h1tsreAQiBt2CQJ+4gzwpfntoSUuNUqE5TDjsbU69p1S4CFz4XX1vAyA36wA= X-Received: by 2002:a05:6000:2207:b0:3a5:8934:4959 with SMTP id ffacd0b85a97d-3b3450a2240mr1717366f8f.27.1751537024220; Thu, 03 Jul 2025 03:03:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEk+YmnervE/9rlaKNpBDo2E1RoLkBUfVqR7jtbbm8XVo68a+HMCOaP16O0KFNsHAN0CxbnUw== X-Received: by 2002:a05:6000:2207:b0:3a5:8934:4959 with SMTP id ffacd0b85a97d-3b3450a2240mr1717328f8f.27.1751537023692; Thu, 03 Jul 2025 03:03:43 -0700 (PDT) Received: from ?IPV6:2a0d:3344:270a:b10:5fbf:faa5:ef2b:6314? ([2a0d:3344:270a:b10:5fbf:faa5:ef2b:6314]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3aba76e40c0sm14156922f8f.59.2025.07.03.03.03.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 03:03:43 -0700 (PDT) Message-ID: <56cb86e1-db38-43c9-857b-f14bb4a5ecd8@redhat.com> Date: Thu, 3 Jul 2025 12:03:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v5 0/4] net: phy: bcm54811: Fix the PHY initialization To: =?UTF-8?B?S2FtaWwgSG9yw6FrICgyTik=?= , Florian Fainelli , Jakub Kicinski Cc: bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org, andrew+netdev@lunn.ch, horms@kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org References: <20250701075015.2601518-1-kamilh@axis.com> <20250702150216.2a5410b3@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/3/25 11:03 AM, Kamil Horák (2N) wrote: > On 7/3/25 01:46, Florian Fainelli wrote: >> On 7/2/25 15:02, Jakub Kicinski wrote: >>> On Tue, 1 Jul 2025 09:50:11 +0200 Kamil Horák - 2N wrote: >>>> PATCH 1 - Add MII-Lite PHY interface mode as defined by Broadcom for >>>>     their two-wire PHYs. It can be used with most Ethernet controllers >>>>     under certain limitations (no half-duplex link modes etc.). >>>> >>>> PATCH 2 - Add MII-Lite PHY interface type >>>> >>>> PATCH 3 - Activation of MII-Lite interface mode on Broadcom bcm5481x >>>>     PHYs >>>> >>>> PATCH 4 - Fix the BCM54811 PHY initialization so that it conforms >>>>     to the datasheet regarding a reserved bit in the LRE Control >>>>     register, which must be written to zero after every device reset. >>>>     Also fix the LRE Status register reading, there is another bit to >>>>     be ignored on bcm54811. >>> >>> I'm a bit lost why the first 3 patches are included in a series for net. >>> My naive reading is we didn't support this extra mode, now we do, >>> which sounds like a new feature.. Patch 4, sure, but the dependency >>> is not obvious. >> >> I don't see the dependency either, at least not in an explicit way. >> Kamil, could patch #4 stand on its own and routed through "net" while >> patches 1-3 are routed through "net-next"? > It can be done this way, however, even the patch #3 is effectively a > fix, not new feature, because the bcm54811 PHY in MLP package only has > MII-Lite interface available externally. As far I know, there is no BGA > casing available for bcm54811 (unlike bcm54810, that one having both MLP > and BGA). Thus, it cannot function without being switched to MII-Lite > mode. The introduction of MII-Lite itself is clearly a new feature and > it is even (theoretically) available for any MII-capable PHY. So if > putting it all to net it is really impossible or contrary to the > net-next vs. net selection rules, let's divide it.... > To get fully functional, bcm54811-based networking, all patches are > necessary so any other user out there must wait for both branches to join. The above makes sense to me, but I think it would be nice to capture some of this info in the cover letter - the fact that many people were confused by the series is an hint the info was indeed missing and required. Please resubmit with an extended cover letter, thanks! (unless Florian jumps in and explicitly asks for something different :-P) Paolo