From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165492AbdEYUH0 (ORCPT ); Thu, 25 May 2017 16:07:26 -0400 Received: from mout.web.de ([212.227.15.3]:49651 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161799AbdEYUHZ (ORCPT ); Thu, 25 May 2017 16:07:25 -0400 Subject: [PATCH 1/2] regmap: Delete an error message for a failed memory allocation in regmap_bulk_write() From: SF Markus Elfring To: Greg Kroah-Hartman , Mark Brown , kernel-janitors@vger.kernel.org Cc: LKML References: <7d7b8131-5aea-cb33-994f-f410dc7cd615@users.sourceforge.net> Message-ID: <56cba529-03eb-9088-3fea-8fbb50c355af@users.sourceforge.net> Date: Thu, 25 May 2017 22:07:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <7d7b8131-5aea-cb33-994f-f410dc7cd615@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:tvCcbDWyO66jhZ3bt6jbCU1llC8JK6807QPF50LPNbXYZ1ObnJe IijJgo3q+ZC3aVdetxY/rSq/Czsl77VYteedZnKV3EzdWxxz3Esb1VNyJIDqKpgBqiABAdj P2syoWref+nX3qi/E0FxO9oZfjRNwoQ2YNw/wnww1Oub5kc6SxyNwACbR0ZOcHfSUXjnJpI CZJeGood45BFCdV+bUYrw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Uqw05nJvxMA=:J7xnX4jiCUdvKomxQHv8EK 1xNbdLTDc82+EmPHJ6BdtbXniEBDNddoCn+8qbXek/MNTuRregQEjhZJVuBrwv1FGVH8GGzaw zV7t1kAFg/NzLMl7XtLMK2wEW8j2d/1r06RIr+lv17ex0gxCzefJDxFkH6LOrYd2bzEMUN+B9 dYVkYY1uqsl+tzpzpTebdYnV1VVgWphf90pAhp0InfRSKDE/riPPXAsSJ8tixjGDaE+jgTpSp GANaC3E66Ki2nwnhNYsknz0UgszB5kM/tItdAcDr934Lk7dHuqUPrnwNLy5BAQh1PqqQ7aHZH ZPBlOwgxMbQJa67pDdbWPs8GJQtjVqofV+fy4U+aE0rTB7sj4pVoy4garI54u8lIWc94LyyrP ZjGYSBncnyaiNKWMgtgAN8Q7if6pMRFtDFvw8iIV40wbhJgcgoFnuQt1FWHq5xSYivyWwhMGm aLw06OFf923FFSs3wkxsun6RYhklSLtJmFkMk0eXp/S6QdlN8R0TXwj+u/VMwYW1j26aJYm7U A05gLI+2UUtguz3txL2NKiRgbLCxmc10vb/S+C/teiV+kWMr4o1ejJaoq8Mk+2xP2jlF3BS3S SxVlVrYEH0Otj2jWQ8H/t5py/bfGLLR5aqDXULYS+23F0Z+xVOkHzwSC88rMktww1a8TLadFI m+O+Zg4ULKatQ3vfoutZlz5UyZCFFCpE1FbhFIIla47ibyDjggPnLeiv0GuJjLVteA6+kKUer F4+PD3dddzbvQgNtQVABcQyMhyLlN5vKv5VRG4wVA5LU3b2Dfbde39zt+yHk2c2uJO8zafd5j /Igyz0B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 May 2017 21:43:58 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/base/regmap/regmap.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index b9a779a4a739..096499e1f223 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1945,10 +1945,9 @@ int regmap_bulk_write(struct regmap *map, unsigned int reg, const void *val, return -EINVAL; wval = kmemdup(val, val_count * val_bytes, map->alloc_flags); - if (!wval) { - dev_err(map->dev, "Error in memory allocation\n"); + if (!wval) return -ENOMEM; - } + for (i = 0; i < val_count * val_bytes; i += val_bytes) map->format.parse_inplace(wval + i); -- 2.13.0