From: Daniel Borkmann <daniel@iogearbox.net>
To: Yanfei Xu <yanfei.xu@windriver.com>,
ast@kernel.org, zlim.lnx@gmail.com, catalin.marinas@arm.com,
will@kernel.org, andrii@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] bpf: avoid unnecessary IPI in bpf_flush_icache
Date: Tue, 1 Jun 2021 19:20:04 +0200 [thread overview]
Message-ID: <56cc1e25-25c3-a3da-64e3-8a1c539d685b@iogearbox.net> (raw)
In-Reply-To: <20210601150625.37419-2-yanfei.xu@windriver.com>
On 6/1/21 5:06 PM, Yanfei Xu wrote:
> It's no need to trigger IPI for keeping pipeline fresh in bpf case.
This needs a more concrete explanation/analysis on "why it is safe" to do so
rather than just saying that it is not needed.
> Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
> ---
> arch/arm64/net/bpf_jit_comp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
> index f7b194878a99..5311f8be4ba4 100644
> --- a/arch/arm64/net/bpf_jit_comp.c
> +++ b/arch/arm64/net/bpf_jit_comp.c
> @@ -974,7 +974,7 @@ static int validate_code(struct jit_ctx *ctx)
>
> static inline void bpf_flush_icache(void *start, void *end)
> {
> - flush_icache_range((unsigned long)start, (unsigned long)end);
> + __flush_icache_range((unsigned long)start, (unsigned long)end);
> }
>
> struct arm64_jit_data {
>
next prev parent reply other threads:[~2021-06-01 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 15:06 [PATCH 0/1] " Yanfei Xu
2021-06-01 15:06 ` [PATCH 1/1] " Yanfei Xu
2021-06-01 17:20 ` Daniel Borkmann [this message]
2021-06-01 17:41 ` Will Deacon
2021-06-02 11:26 ` Xu, Yanfei
2021-06-02 17:26 ` Will Deacon
2021-06-03 10:29 ` Xu, Yanfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56cc1e25-25c3-a3da-64e3-8a1c539d685b@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=will@kernel.org \
--cc=yanfei.xu@windriver.com \
--cc=yhs@fb.com \
--cc=zlim.lnx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®