From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE4BF435AB2 for ; Mon, 10 Aug 2026 18:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385574; cv=none; b=EjGiMHznPBo2sly/LSki0vOWzM+tL7rQI7LIm8Yve+qci44m5EbFyjJeJSZ+8FttZwGBc5xByoN/DQsaXTHiVpbiFxAWm1jfqQ1DgoM6bINqVC0lQHJqbrFAaixZYAE/+EKKAVvo2OCpnawP6H3AXhzpexFzv1FOSmcg+4jF0Xk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385574; c=relaxed/simple; bh=4uAUdRcTYsGvQc18W+1whd/BeJC4brhFOFvRVgZD2sE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q1lkJ8cM/QB3xpBzV0NHDJi1Lr280YNDiSc1ky+mqeb8qRdhxCvJtunEkOJ9Tu6AZ+NSFo9PuuVHb2FSynLftZJBZLm5l/tTwxeJ56d0Xu/mZfEtqCRhw73btDLmbzfJKznxc9xXz+P2veCpW5OkBUicCzt+Bv4si02Ut2fA4ck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h7jZJEeF; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h7jZJEeF" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38511175ad3so2085887a91.2 for ; Mon, 10 Aug 2026 11:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786385572; x=1786990372; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+O3RP4khGolVisKEaJPPZ/5KR4V4I9tZWSXBQpVzFB0=; b=h7jZJEeFEZyFI3BXTxR59L8uy/XpF7RpzU4gJcuerop6yHNwSfHQ1icS81G0/fK+Xt 3wZWXjl6lSL3DvwlE5BMCRR+1Z2kSdL0D/fWKpQMlBq9jzRIC3tVHdHUib0VFJZEU6hr cgjZNy1L1boBFDqd5sc/VqwNdMy/MkN29D9wwM6smzDeK4eKoywMPN5HtLu6pbzCvvWA Q+qJP17/2u2ObAO1I/1nor7dXOtF4u8oA9o1yYgiAo9s+UiHPfSjUxFmu9MRJJMpLUmc RS9R5b025HIabNyIpWXbdLS3r9SHhtg7yYXv+pvEooouBNbbUT687Xcsd7xRvEfK1gib RWAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385572; x=1786990372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+O3RP4khGolVisKEaJPPZ/5KR4V4I9tZWSXBQpVzFB0=; b=GkwmpLZHTbAeBm/SyIZtXnY9RIdtznE5AeqUenl4vi84wTzVFT0Zjy8NEtEXkd/B8F FjHzdSbgyRapYf+n3afQMAAlhm/ZgQYLfEK97eO1FIT5g5g2/dv24vxmgpBM6FgyBmkD 8ENX+8uM7xX+KqdUx/XsncAsrl+zyF6KICE//dJsFwT/qfCFTLoqeRSiIDVsUR+072e1 zJ/yIvwCJbIbetmA80qCKnEK5o61RsYs0/nxrIO6WISH/Kg9ZiUxYdPX7AnNtLuvxQuI U9QsUIurC1pzS9/1tUAArUObE3EiZ6cAPTq5nRiTGf2wBKJUtN3VZ4OSDGuw6pHMEad6 VERg== X-Forwarded-Encrypted: i=1; AHgh+Roe5hSg/z/kfrGuUkvmr84eNgRS+1+2MpO/Pk7ni1VadIEU8M7d6yYce7GSvcbXhHpKaMzTmr2YvmrcMIs=@vger.kernel.org X-Gm-Message-State: AOJu0YzVYZkpA5FuCV42/fckzPsoFdvo9d5WKk16LDhiAzgvJsaiPMBf 4/ayJooWtUzD0iWx8dWDcM8vpLqPGrJpMqUkuPwuzGqe9xPRczh1T01V X-Gm-Gg: AR+sD10odo6nrTCSs8tsQqVAGrBtnUSU277v/5SUu5A1ZnK3EdoxtNeI0Fqd0ZLOyzo FawUXioA9wC3rOGdbYex7VOQ8hg4cAhaSxLdZsV92oRik1/ZRfN6+OWcqA5lW53DHYOTSKDyKSv Fxltd3XA2AtDrthwZiGqHlDALMLL2/nvFj/gXVGICztXoEo7AMy9rbWqDbtpBWT9sytj0W2f0sZ uL9vsTnaPEBET5jFqA+SuBTqUI4Hso/FqSUqDA9q34n3J4DU78djE6a979kU9fEqgMMf8ALrEWF f/gpZqHwFLpWAVwOUJOX+7kPlQbpgu6nJ5dtBgscthifDisT9UllXDfPfmE+arkD/TDkO3y2yRE 99swSD6Yfl+Vs/lKFD8OapwHbPcOEXtkb0akPXKuT+ldUULOoOARa628zlQ5pTSw5GKDqSWsOuY pCeBl9m2N5wNesLMvOdq5lEZLm5oJLp0bsbccT9w1h2mLMB1Hv2j3HmpO1sYqauokbDOqfEN/uy w== X-Received: by 2002:a17:90b:4990:b0:38e:4114:d8c7 with SMTP id 98e67ed59e1d1-392cc6da1e6mr3394837a91.0.1786385571937; Mon, 10 Aug 2026 11:12:51 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fa9:fa00:b1a9:6513:83c6:1d23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d53b873asm472795a91.17.2026.08.10.11.12.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:12:51 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Michal Simek , Abin Joseph , Sakari Ailus , linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 21/34] dmaengine: zynqmp-dma: switch completion tasklet to dmaengine BH Date: Mon, 10 Aug 2026 11:09:22 -0700 Message-ID: <56dce14420ecdf8665c0e03b5f3a42004d33eadd.1786384169.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-channel tasklet with the shared dmaengine BH helper. The handler continues to run in softirq context while dmaengine owns the common scheduling and teardown mechanism. Signed-off-by: Allen Pais --- drivers/dma/xilinx/zynqmp_dma.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index f6a812e49ddc..e396a35f0e0d 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -207,7 +207,6 @@ struct zynqmp_dma_desc_sw { * @dev: The dma device * @irq: Channel IRQ * @is_dmacoherent: Tells whether dma operations are coherent or not - * @tasklet: Cleanup work after irq * @idle : Channel status; * @desc_size: Size of the low level descriptor * @err: Channel has errors @@ -232,7 +231,6 @@ struct zynqmp_dma_chan { struct device *dev; int irq; bool is_dmacoherent; - struct tasklet_struct tasklet; bool idle; size_t desc_size; bool err; @@ -735,7 +733,7 @@ static irqreturn_t zynqmp_dma_irq_handler(int irq, void *data) writel(isr, chan->regs + ZYNQMP_DMA_ISR); if (status & ZYNQMP_DMA_INT_DONE) { - tasklet_schedule(&chan->tasklet); + dmaengine_schedule_bh(&chan->common); ret = IRQ_HANDLED; } @@ -744,7 +742,7 @@ static irqreturn_t zynqmp_dma_irq_handler(int irq, void *data) if (status & ZYNQMP_DMA_INT_ERR) { chan->err = true; - tasklet_schedule(&chan->tasklet); + dmaengine_schedule_bh(&chan->common); dev_err(chan->dev, "Channel %p has errors\n", chan); ret = IRQ_HANDLED; } @@ -760,11 +758,12 @@ static irqreturn_t zynqmp_dma_irq_handler(int irq, void *data) /** * zynqmp_dma_do_tasklet - Schedule completion tasklet - * @t: Pointer to the ZynqMP DMA channel structure + * @c: Pointer to the ZynqMP DMA channel structure */ -static void zynqmp_dma_do_tasklet(struct tasklet_struct *t) +static void zynqmp_dma_do_tasklet(struct dma_chan *c) { - struct zynqmp_dma_chan *chan = from_tasklet(chan, t, tasklet); + struct zynqmp_dma_chan *chan = container_of(c, + struct zynqmp_dma_chan, common); u32 count; unsigned long irqflags; @@ -815,7 +814,7 @@ static void zynqmp_dma_synchronize(struct dma_chan *dchan) { struct zynqmp_dma_chan *chan = to_chan(dchan); - tasklet_kill(&chan->tasklet); + dmaengine_kill_bh(&chan->common); } /** @@ -887,7 +886,7 @@ static void zynqmp_dma_chan_remove(struct zynqmp_dma_chan *chan) if (chan->irq) devm_free_irq(chan->zdev->dev, chan->irq, chan); - tasklet_kill(&chan->tasklet); + dmaengine_kill_bh(&chan->common); list_del(&chan->common.device_node); } @@ -937,7 +936,7 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev, chan->is_dmacoherent = of_property_read_bool(node, "dma-coherent"); zdev->chan = chan; - tasklet_setup(&chan->tasklet, zynqmp_dma_do_tasklet); + dmaengine_init_bh(&chan->common, zynqmp_dma_do_tasklet); spin_lock_init(&chan->lock); INIT_LIST_HEAD(&chan->active_list); INIT_LIST_HEAD(&chan->pending_list); -- 2.43.0