From: Floris Kraak <randakar@gmail.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Robert Hancock <hancockrwd@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Trivial Patch Monkey <trivial@kernel.org>,
Andreas Schwab <schwab@suse.de>
Subject: Re: [PATCH]: Cleanup: Remove gcc format string warnings when compiling with -Wformat-security
Date: Thu, 5 Feb 2009 23:41:34 +0100 [thread overview]
Message-ID: <56e1b5710902051441g69b2df61n6f6b77a3dc59ac42@mail.gmail.com> (raw)
In-Reply-To: <adak584jzw3.fsf@cisco.com>
On Thu, Feb 5, 2009 at 11:13 PM, Roland Dreier <rdreier@cisco.com> wrote:
>
> I would strongly prefer to do this with a little more care. For example
> the b43/main.c change:
>
> > --- a/drivers/net/wireless/b43/main.c
> > +++ b/drivers/net/wireless/b43/main.c
> > @@ -2005,9 +2005,9 @@ static void b43_print_fw_helptext(struct b43_wl
> > *wl, bool error)
> > "http://linuxwireless.org/en/users/Drivers/b43#devicefirmware "
> > "and download the latest firmware (version 4).\n";
> > if (error)
> > - b43err(wl, text);
> > + b43err(wl, "%s", text);
> > else
> > - b43warn(wl, text);
> > + b43warn(wl, "%s", text);
> > }
> would probably be better solved by doing
>
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -1999,11 +1999,11 @@ static void b43_release_firmware(struct b43_wldev *dev)
>
> static void b43_print_fw_helptext(struct b43_wl *wl, bool error)
> {
> - const char *text;
> + static const char text[] =
> + "You must go to "
> + "http://linuxwireless.org/en/users/Drivers/b43#devicefirmware "
> + "and download the latest firmware (version 4).\n";
>
> - text = "You must go to "
> - "http://linuxwireless.org/en/users/Drivers/b43#devicefirmware "
> - "and download the latest firmware (version 4).\n";
> if (error)
> b43err(wl, text);
> else
>
Fair enough. I'm going to have to break this down into categories of
bugs probably anyway. - "trivial just makes the compiler stops
whining" vs "omg security hole" and the shades in between. From what
I've seen so far the vast majority of this falls into the first
category though ;-)
> and in any case I'm not totally convinced that we want to add the bloat
> for trivial cases like
>
> char *safe = "foo";
> printk(safe);
>
> Would be nice to think of a cleverer way to handle that...
>
It would help if GCC was a little smarter in the detection, right now
it gives a lot of false positives even on code like that.
When I was playing around with coccinelle tonight in a (probably
misguided) attempt to automate this I found a few new possible cases
where macro wrappers around printk() seem to make avoiding this check
possible. Haven't looked deeply yet, I'm doing this on my spare time
which I don't have tons of ;-)
Regards,
Floris
---
"They that give up essential liberty to obtain temporary safety,
deserve neither liberty nor safety."
-- Ben Franklin
"The course of history shows that as a government grows, liberty
decreases."
-- Thomas Jefferson
next prev parent reply other threads:[~2009-02-05 22:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 14:41 [PATCH]: Cleanup: Remove gcc format string warnings when compiling with -Wformat-security (was: Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag) Floris Kraak
2009-02-05 14:52 ` Ingo Molnar
2009-02-05 15:22 ` Mike Isely
2009-02-05 15:38 ` Floris Kraak
2009-02-05 16:34 ` Floris Kraak
2009-02-05 22:13 ` [PATCH]: Cleanup: Remove gcc format string warnings when compiling with -Wformat-security Roland Dreier
2009-02-05 22:41 ` Floris Kraak [this message]
2009-02-05 23:42 ` Robert Hancock
2009-02-06 10:36 ` Floris Kraak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56e1b5710902051441g69b2df61n6f6b77a3dc59ac42@mail.gmail.com \
--to=randakar@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hancockrwd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=sam@ravnborg.org \
--cc=schwab@suse.de \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®