From: Prashanth K <quic_prashk@quicinc.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>, Hongyu Xie <xy521521@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>, <stable@kernel.org>,
Hongyu Xie <xiehongyu1@kylinos.cn>,
Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: Re: [PATCH] xhci: Keep interrupt disabled in initialization until host is running.
Date: Fri, 22 Sep 2023 16:03:26 +0530 [thread overview]
Message-ID: <56e210a4-8106-db7a-f44d-e40421e5abf7@quicinc.com> (raw)
In-Reply-To: <2023092256-smudge-disallow-48d3@gregkh>
On 22-09-23 04:00 pm, Greg Kroah-Hartman wrote:
> On Fri, Sep 22, 2023 at 02:51:41PM +0530, Prashanth K wrote:
>> From: Hongyu Xie <xy521521@gmail.com>
>>
>> [ Upstream commit 808925075fb750804a60ff0710614466c396db4 ]
>>
>> irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
>> in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
>> It's possible that you will receive thousands of interrupt requests
>> after initialization for 2.0 roothub. And you will get a lot of
>> warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
>> disabled?". This amount of interrupt requests will cause the entire
>> system to freeze.
>> This problem was first found on a device with ASM2142 host controller
>> on it.
>>
>> [tidy up old code while moving it, reword header -Mathias]
>>
>> Cc: stable@kernel.org
>> Signed-off-by: Hongyu Xie <xiehongyu1@kylinos.cn>
>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>> Link: https://lore.kernel.org/r/20220623111945.1557702-2-mathias.nyman@linux.intel.com
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> ---
>> drivers/usb/host/xhci.c | 34 +++++++++++++++++++++-------------
>> 1 file changed, 21 insertions(+), 13 deletions(-)
>
> What stable kernel(s) are you asking this to be applied to?
>
> greg k-h
Need this patch on v5.15, I had cc'ed "stable@kernel.org # 5.15", but
looks like it didn't work. Should I resend this with SOB and CC tags?
Thanks,
Prashanth K
next prev parent reply other threads:[~2023-09-22 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 9:21 Prashanth K
2023-09-22 10:30 ` Greg Kroah-Hartman
2023-09-22 10:33 ` Prashanth K [this message]
2023-09-22 10:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56e210a4-8106-db7a-f44d-e40421e5abf7@quicinc.com \
--to=quic_prashk@quicinc.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=stable@kernel.org \
--cc=xiehongyu1@kylinos.cn \
--cc=xy521521@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®