mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Yu Kuai <yukuai3@huawei.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Eric Anholt <eric@anholt.net>,
	Navid Emamdoost <navid.emamdoost@gmail.com>,
	dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Yi Zhang <yi.zhang@huawei.com>, zhengbin <zhengbin13@huawei.com>
Subject: Re: [PATCH V2] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl
Date: Mon, 27 Jan 2020 08:20:48 +0100	[thread overview]
Message-ID: <56e99398-15be-aeb0-32b3-aa8a20d71e97@web.de> (raw)

> kfree() was called for the same variable twice within an if branch.

I wonder still how this software situation happened.


Now I imagine that it could be more logical to delete the second of
this function call if you would like to look at the history of previous
two patches once more.


How do you think about to add another jump target for a bit of common
exception handling?

Regards,
Markus

             reply	other threads:[~2020-01-27  7:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27  7:20 Markus Elfring [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-12-30  1:40 yu kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56e99398-15be-aeb0-32b3-aa8a20d71e97@web.de \
    --to=markus.elfring@web.de \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=navid.emamdoost@gmail.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®