From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Li, Meng" <Meng.Li@windriver.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"dinguyen@kernel.org" <dinguyen@kernel.org>,
"hminas@synopsys.com" <hminas@synopsys.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] usb: dwc2: Add platform specific data for Intel Stratix10 platform
Date: Wed, 19 Jul 2023 11:20:42 +0200 [thread overview]
Message-ID: <56ef499c-d47a-19a1-2542-5e8a7c86d510@linaro.org> (raw)
In-Reply-To: <PH0PR11MB519152C26157460397FA73E2F139A@PH0PR11MB5191.namprd11.prod.outlook.com>
On 19/07/2023 11:10, Li, Meng wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Wednesday, July 19, 2023 2:40 PM
>> To: Li, Meng <Meng.Li@windriver.com>; gregkh@linuxfoundation.org;
>> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
>> dinguyen@kernel.org; hminas@synopsys.com; linux-usb@vger.kernel.org;
>> devicetree@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH 1/3] usb: dwc2: Add platform specific data for Intel Stratix10
>> platform
>>
>> CAUTION: This email comes from a non Wind River email account!
>> Do not click links or open attachments unless you recognize the sender and
>> know the content is safe.
>>
>> On 19/07/2023 04:55, Meng Li wrote:
>>> Intel Stratix10 is very the same with Agilex platform, the DWC2 IP on
>>> the Stratix platform also does not support clock-gating. So, refer to
>>> commit 3d8d3504d233("usb: dwc2: Add platform specific data for Intel's
>>> Agilex"), add platform specific data for Intel Stratix10 platform.
>>>
>>> Signed-off-by: Meng Li <Meng.Li@windriver.com>
>>> ---
>>> drivers/usb/dwc2/params.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
>>> index 8eab5f38b110..3d085ae1ecd8 100644
>>> --- a/drivers/usb/dwc2/params.c
>>> +++ b/drivers/usb/dwc2/params.c
>>> @@ -267,6 +267,8 @@ const struct of_device_id dwc2_of_match_table[] = {
>>> .data = dwc2_set_stm32mp15_hsotg_params },
>>> { .compatible = "intel,socfpga-agilex-hsotg",
>>> .data = dwc2_set_socfpga_agilex_params },
>>> + { .compatible = "intel,socfpga-stratix10-hsotg",
>>> + .data = dwc2_set_socfpga_agilex_params },
>>
>> NAK. I already wrote why.
>
> If I don't add the SoC specific compatible entry, how I use to the specific data on Stratix10 platform.
You do not have match data specific to Stratix10. I explained already
that I expect them to be compatible. I gave you example how it is done.
What is unclear in that example?
> If you think the new SoC specific compatible entry is not necessary, the patch2 also has issue.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-19 9:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 2:55 [PATCH 0/3] Patches used to add " Meng Li
2023-07-19 2:55 ` [PATCH 1/3] usb: dwc2: Add " Meng Li
2023-07-19 6:39 ` Krzysztof Kozlowski
2023-07-19 9:10 ` Li, Meng
2023-07-19 9:20 ` Krzysztof Kozlowski [this message]
2023-07-19 2:55 ` [PATCH 2/3] arm64: dts: agilex: use the compatible "intel,socfpga-agilex-hsotg" Meng Li
2023-07-19 2:55 ` [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga-stratix10-hsotg" Meng Li
2023-07-19 6:39 ` Krzysztof Kozlowski
2023-07-19 8:45 ` Li, Meng
2023-07-19 8:59 ` Krzysztof Kozlowski
2023-07-19 9:49 ` Li, Meng
2023-07-19 9:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ef499c-d47a-19a1-2542-5e8a7c86d510@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Meng.Li@windriver.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®