From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC90C34050 for ; Wed, 19 Feb 2020 10:57:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32F06206DB for ; Wed, 19 Feb 2020 10:57:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zzsVtrNa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726609AbgBSK5k (ORCPT ); Wed, 19 Feb 2020 05:57:40 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40648 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726469AbgBSK5k (ORCPT ); Wed, 19 Feb 2020 05:57:40 -0500 Received: by mail-wr1-f67.google.com with SMTP id t3so27660949wru.7 for ; Wed, 19 Feb 2020 02:57:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XbVzBlTzmMUb2Tui5d1tff0RCyFoEaGMTP5xbXMfFog=; b=zzsVtrNanulY/mngUlst4INjYwfO7oe6NjEiCEOQ2DdCeylsbEXEfNxjrB32+F74cw FnNXVYE+P46yRQocLtm+bg4/BtasFaxagt4BPpDPIWNYNFuldCG7zE3qzcKHAw2OMTQ2 ach3BEo29K06KggpiW17sffaCPd/dfhKZSFsCxQHpG4YdwUeYCOtcb/T8DDDP3gYj24l /jF3//Lgb6Em0kT7GEiy51/mb/pjxV1JJ55mSfF0ZUNYntSNvhuUrGQ8nYVpsv6wRy3r 0Q0nWdnoIabKpitT+KwKXFGaNmsW3KUEGIcmt1ocL7fHq1Z8c/KQBHcctSbwcjHte1Id mYrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XbVzBlTzmMUb2Tui5d1tff0RCyFoEaGMTP5xbXMfFog=; b=r7hZBGOmeXE8rrnLERMyxjud27YE1JnC5P+I3zLO2PZMFebszp5Od+VZkAKxUY/2Av zKLxXFM+eSSHPQgDNeNVzW4oygbaS1CuBLmMlyAqPo5y5dcjmEjnvyRNBbL9b71mx5mV DeSitlX5zHSyyV8wQGKhox3pwdqIdcKlTcwg1bhJ8ei/dvURWte/lYhXrLANG1oY411z etmkaibcU/Xt62TYh+koNLjzX5IP6JUSrXir99hKBPYq7TtEqHEmTWOkdoR8NGqo1tZ9 rJlnZbSt3+OTUVZ753Wa4b4z7qVc57C05V+oVwB6eFNgn1LVQaNiDYt2RVUU3vZJckcq aHjg== X-Gm-Message-State: APjAAAXKJWGZoyZZrViGMQPYPmqd8NfSDjCQpzqZerH8DBbS+eQOHtBG lH8uW2v1a9jy3FbQ+xPknYuwPw== X-Google-Smtp-Source: APXvYqwg9YyFLCEoecAsCJ8HXP+2fq8Io/qWMo1OmnwtGkM9ljAYSw/lwW8zQy81/NLD9oy1vhYbXg== X-Received: by 2002:adf:9c8d:: with SMTP id d13mr37236416wre.392.1582109858386; Wed, 19 Feb 2020 02:57:38 -0800 (PST) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id y185sm2617910wmg.2.2020.02.19.02.57.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Feb 2020 02:57:37 -0800 (PST) Subject: Re: [PATCH v3 7/7] nvmem: add a comment about resource management To: Bartosz Golaszewski , Linus Walleij , Khouloud Touil , Geert Uytterhoeven Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20200219092218.18143-1-brgl@bgdev.pl> <20200219092218.18143-8-brgl@bgdev.pl> From: Srinivas Kandagatla Message-ID: <56f38e71-7572-55ac-d5ae-dfbe5c2345f7@linaro.org> Date: Wed, 19 Feb 2020 10:57:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200219092218.18143-8-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/02/2020 09:22, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The fact that part of the resources associated with the nvmem resources > is freed by the release() callback in device_type caused me some > confusion. Add a comment explaining that to nvmem_register(). I see this patch totally unnecessary! I expect people creating patch in this area to understand what exactly they are doing. This is not going to help them in anyway, other than misleading and re-documenting device_add which is already available at https://www.kernel.org/doc/html/v5.5/driver-api/infrastructure.html thanks, srini > > Signed-off-by: Bartosz Golaszewski > --- > drivers/nvmem/core.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 40fe5913c264..6e28f3fddf53 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -397,6 +397,11 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) > > dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", config->name); > > + /* > + * After calling device_add() we can stop freeing previously > + * allocated resources - they'll be freed from nvmem_release() > + * when the device's reference count drops to 0. > + */ > rval = device_add(&nvmem->dev); > if (rval) > goto err_put_device; >