From: Jaehoon Chung <jh80.chung@samsung.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 0/3] Cleanup setup_clock callback from dw_mmc
Date: Mon, 04 Apr 2016 08:46:48 +0900 [thread overview]
Message-ID: <5701AB68.2080208@samsung.com> (raw)
In-Reply-To: <1459409616-20306-1-git-send-email-shawn.lin@rock-chips.com>
Hi,
Picked this patch-set on my repository.
Best Regards,
Jaehoon Chung
On 03/31/2016 04:33 PM, Shawn Lin wrote:
> Hello Jeahoon
>
> Currently dw_mmc is a little too queen-size. As we had cleanup
> prepare_command callback some days before, there are also some
> ones deserve to remove. Also we should avoid add new quirks or
> callbacks into dw_mmc in order to avoid the dilemma sdhci meets
> now.
>
> This patchset remove setup_clock callback. Obviously, add a callback
> just for one-time-used clk stuff make no sense. We combine what
> setup_clock does before into init callback. For exynos platfrom, it
> needs call init hook after resume, so we add new argument in init hook
> to indicate whether it needs do clk stuff or not.
>
>
> Changes in v2:
> - rebase on linux-mmc next
> - remove add setup_clk flag for init callback
>
> Shawn Lin (3):
> mmc: dw_mmc-rockchip: remove setup_clock for rockchip
> mmc: dw_mmc-exynos: remove dw_mci_exynos_setup_clock
> mmc: dw_mmc: remove setup_clock callback
>
> drivers/mmc/host/dw_mmc-exynos.c | 8 --------
> drivers/mmc/host/dw_mmc-rockchip.c | 12 ++++--------
> drivers/mmc/host/dw_mmc.c | 9 ---------
> drivers/mmc/host/dw_mmc.h | 2 --
> 4 files changed, 4 insertions(+), 27 deletions(-)
>
prev parent reply other threads:[~2016-04-03 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 7:33 Shawn Lin
2016-03-31 7:33 ` [PATCH v2 1/3] mmc: dw_mmc-rockchip: remove setup_clock for rockchip Shawn Lin
2016-03-31 7:34 ` [PATCH v2 2/3] mmc: dw_mmc-exynos: remove dw_mci_exynos_setup_clock Shawn Lin
2016-03-31 7:34 ` [PATCH v2 3/3] mmc: dw_mmc: remove setup_clock callback Shawn Lin
2016-04-01 0:27 ` [PATCH v2 0/3] Cleanup setup_clock callback from dw_mmc Jaehoon Chung
2016-04-03 23:46 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5701AB68.2080208@samsung.com \
--to=jh80.chung@samsung.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome