mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nikolay Borisov <kernel@kyup.com>
To: Andy Lutomirski <luto@kernel.org>, x86@kernel.org
Cc: Borislav Petkov <bp@alien8.de>,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH] x86: Add a turbo mode sysctl
Date: Mon, 4 Apr 2016 09:48:23 +0300	[thread overview]
Message-ID: <57020E37.4000302@kyup.com> (raw)
In-Reply-To: <cd6157244ae75145e2529a1d73f6174cd829ac9c.1459525715.git.luto@kernel.org>



On 04/01/2016 06:49 PM, Andy Lutomirski wrote:
> Sadly, hardware turbo mode buttons are few and far between in these
> degenerate times.  Add a software control at /proc/sys/turbo_mode.
> 
> Unfortunately, Linux graphical environments have become very
> heavy-weight and are essentially unusable on non-Turbo systems.  The
> VT console works very well, though.
> 
> Due to KVM limitations, turbo mode is permanently on in a KVM guest.
> 
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
>  arch/x86/mm/pat.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 61 insertions(+), 2 deletions(-)


The name of the sysctl really sucks, it just control whether caching is
enabled/disabled. Now, having said that I realize there are multiple
sysctl that contain "cache" in their names. But can you come up with a
more descriptive name, directly relating to what the sysctl does and now
what its actual effects are :)? Also, aren't caches enabled by the
kernel when the system is booting, according to SDM1/section 9.3 caches
are disabled after reset and I assume the kernel does enable them when
it's booting?

      parent reply	other threads:[~2016-04-04  6:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 15:49 Andy Lutomirski
2016-04-01 16:05 ` Borislav Petkov
2016-04-01 16:07 ` kbuild test robot
2016-04-01 16:10 ` Thomas Gleixner
2016-04-02 20:21   ` Andy Lutomirski
2016-04-03  9:55     ` Thomas Gleixner
2016-04-03 10:12       ` Borislav Petkov
2016-04-04  6:48 ` Nikolay Borisov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57020E37.4000302@kyup.com \
    --to=kernel@kyup.com \
    --cc=bp@alien8.de \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome