From: Peter Hurley <peter@hurleysoftware.com>
To: Brian Bloniarz <brian.bloniarz@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org, tsi@tuyoix.net
Subject: Re: [PATCH v3] Fix OpenSSH pty regression on close
Date: Mon, 4 Apr 2016 20:43:10 -0700 [thread overview]
Message-ID: <5703344E.6060300@hurleysoftware.com> (raw)
In-Reply-To: <20160306061057.GA25727@adaptasaurus>
On 03/06/2016 01:16 PM, Brian Bloniarz wrote:
> OpenSSH expects the (non-blocking) read() of pty master to return
> EAGAIN only if it has received all of the slave-side output after
> it has received SIGCHLD. This used to work on pre-3.12 kernels.
>
> This fix effectively forces non-blocking read() and poll() to
> block for parallel i/o to complete for all ttys. It also unwinds
> these changes:
>
> 1) f8747d4a466ab2cafe56112c51b3379f9fdb7a12
> tty: Fix pty master read() after slave closes
>
> 2) 52bce7f8d4fc633c9a9d0646eef58ba6ae9a3b73
> pty, n_tty: Simplify input processing on final close
>
> 3) 1a48632ffed61352a7810ce089dc5a8bcd505a60
> pty: Fix input race when closing
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
prev parent reply other threads:[~2016-04-05 3:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 21:16 Brian Bloniarz
2016-03-19 20:40 ` Brian Bloniarz
2016-03-19 20:59 ` Greg Kroah-Hartman
2016-03-19 21:09 ` Peter Hurley
2016-04-05 3:43 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5703344E.6060300@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=brian.bloniarz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tsi@tuyoix.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome