mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [ANNOUNCE] Git v2.8.1 (and call-for-help to "make rpmbuild" users)
Date: Tue, 5 Apr 2016 11:49:24 +0200	[thread overview]
Message-ID: <57038A24.2030808@drmicha.warpmail.net> (raw)
In-Reply-To: <xmqqtwjiebw2.fsf@gitster.mtv.corp.google.com>

Junio C Hamano venit, vidit, dixit 03.04.2016 21:21:
> If you do not build RPM binary packages from our pristine source,
> you can safely ignore this release and stop reading this message.
> 
> Now that the audience of this message has been limited to a narrow
> target, before I make an announcement, here is a call-for-help to
> you.
> 
> Git v2.8 removed README file and added a corresponding README.md
> file.  The change however did not adjust git.spec.in that still
> referred to README, causing "make rpmbuild" to fail.  The breakage
> was not noticed by anybody who tested v2.8.0-rc0 and later release
> candidates, and ended up in the final v2.8 release, and we saw a
> handful of bug reports on the list after the release happened.
> 
> This maintenance release is to correct this bug for those who run
> "make rpmbuild". It has no other changes.
> 
> It is clear that nobody who relies on being able to "make rpmbuild"
> ever tried any of the 5 release candidate snapshots that happened
> during Feb 26-Mar 28.  We had a whole month and nobody noticed?
> 
> This incident clearly shows that something needs to happen, if
> people want "make rpmbuild" to keep working.  Even though this
> maintenance release may fix this single bug, breakages similar to it
> that only affect "make rpmbuild" users are guaranteed to appear in
> future releases, unless those who can prevent them from happening
> start helping to test at least release candidate snapshots.

In RedHat/Fedora land, we use our own spec files, "make" and "make
install" into a special purpose tree and package that.

E.g. in fedora, the packager noticed the README file name change in
2.8.0, adjusted the corresponding "%doc" line, and that was basically
all besides updating the sources.

As a fedora user, I either use rpms targetting fedora (possibly patched
and rebuilt by myself), or I build from sources (--prefix=$HOME). With
"generic" rpms you never know which guidelines they follow or where they
install to. Also, naming schemes for dependencies may differ between
RedHat land, SuSe land and other rpm based distros.

So, just like in the deb case, I'm wondering if there's a use case for
make rpmbuild in git.git.

Michael

  reply	other threads:[~2016-04-05  9:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-03 19:21 Junio C Hamano
2016-04-05  9:49 ` Michael J Gruber [this message]
2016-04-05 10:39 ` Elia Pinto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57038A24.2030808@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®