From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757737AbcDGVjW (ORCPT ); Thu, 7 Apr 2016 17:39:22 -0400 Received: from mail-by2on0105.outbound.protection.outlook.com ([207.46.100.105]:35760 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753800AbcDGVjT (ORCPT ); Thu, 7 Apr 2016 17:39:19 -0400 Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=hpe.com; Message-ID: <5706D36E.3060205@hpe.com> Date: Thu, 7 Apr 2016 17:38:54 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Tejun Heo CC: "Theodore Ts'o" , Andreas Dilger , Christoph Lameter , , , Scott J Norton , Douglas Hatch , Toshimitsu Kani Subject: Re: [PATCH 2/3] percpu_stats: Simple per-cpu statistics count helper functions References: <1459566578-30221-1-git-send-email-Waiman.Long@hpe.com> <1459566578-30221-3-git-send-email-Waiman.Long@hpe.com> <20160404160228.GW7822@mtj.duckdns.org> <570584F1.10909@hpe.com> <20160406225424.GK24661@htj.duckdns.org> <57068395.1080703@hpe.com> <20160407160623.GF7822@mtj.duckdns.org> <5706AC71.3080801@hpe.com> <20160407185827.GH7822@mtj.duckdns.org> <5706C4F2.6020108@hpe.com> <20160407204114.GJ7822@mtj.duckdns.org> In-Reply-To: <20160407204114.GJ7822@mtj.duckdns.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.60] X-ClientProxiedBy: CY1PR20CA0099.namprd20.prod.outlook.com (10.164.213.153) To DF4PR84MB0314.NAMPRD84.PROD.OUTLOOK.COM (10.162.193.28) X-MS-Office365-Filtering-Correlation-Id: f60ab15e-f615-4bc1-7734-08d35f2d116c X-Microsoft-Exchange-Diagnostics: 1;DF4PR84MB0314;2:agratnmnfPRljdDTeIh5xQrWgqeF8ovdeXQJRZeMUJn60GXJYLutPErEpYpDe6Q0+4YabBaVGTg6Au3hWpctM94sJQ/15JemWEqDtNO7h5s7iOqMtAmHrZo9qJUkxVh+TMoMm7p8EP+ouBi1tubpxcjEPkOG3COgEC54zQl+kYRqBwGs9+8fgR/fobusrtyG;3:0L3A+DZ6qUr2CJRBSHdG2e6HgyC1PlJUQQ91ukVIJkiMUZHlisaEormHl5NGPPV9zLg27nHXeLkaVBw+ynvvzMGlkeMqwXvDj62lWVGT1TTsyviH0RD3l5aILtvwDCsz;25:OQ2/QnmTZMD+WNmmPLgclrQWfY2/Dju+bsKMutCTocUVDlh3KlpYgQZXCUejM5FksPFAlRxISQjbtS4Pu13nu3YtLVn5NgNKpNuUYm2evNBGfmJPU43Z9cYLsAbDK4BMr8WCTEk614jVplpS8IN86XTyQwl+JwkAskl8I+aoAMOHyYeBWP8ifzPIREEwroumVgc3EiB3CYUTpaADHYq9LHrv7OU+5DK2igzuse0SqYrwlaO9bKiICWsjxBehlZKz+MsNIPwpq3bWYuom9pjIv9qed/WYU6EltjyOd/00akjSUdMqLnAglvMXW+qWzdwVJVHn0wJFU3trvhv9DuxQn7Rv8kPh2a8kYOweoBpFie9L5YwP173YOMk+jS5OpFcJd/zq1z5Tvz9dwgFQLQwKvC9A2Zr5AgrdZKeWS/rUhtJysqbR8CboPhFL1SvE1y+bGAaBTHzAVGy9CZnOLgeYdW96KKve5Uk9mC6UWf+oyldHz5HWb7/bNl/EryHGe3/3XZ402VCFJpcBAd3jPeu8z/5+lxCIqo35qQ0SFZWRBczGMkke1/L90g2Pu6/H2Gg6dePtfVRsO3liaO6M7Lsmkg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DF4PR84MB0314; X-LD-Processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;DF4PR84MB0314;20:fq4PWS5zJC1TU1loZwPug4FdzcSGW6EMgwLGYnIfPFrwUnT450PeFapICKmgklsucsm1NdbZc15Typ7ij7osOtJTgnXUYfGcFHJiuhluO41vt26abmACPdWD//OhNsRXaRW4iqvbGZs4XRiardWy/IRpok/yJOhRcKcMPH8/O5gOo7F50uLWkdXST4ZC01n4n2e7vg0geK2lOfY7Vnuh4qlesUHTz3hTI3B3HKm8x+qAq3gjOg2QYNvnn08omvvwDYOAOr3ieC67USocqaSscBjv7Qh0xiIMFgF8hj2H7FhHQltvEq6gzMBAuAq27uIAnmqouu9Nhnl4/f6dJSR+mg==;4:c9aVmj4Zf5skOAaKbS62F0J+nxxicJrceqk6ravsxKp4AYxY7J1DQwHx8W1JoLiICzAdINYRhf95ZmcvzlltQwclR5dt5nbQBaKOmJ8CYbhr4OMC00oeYTmeGu4c64QhLgkVJmJMEzq4hSR3oaUUi8Gl+pJ1Ay7JUS/XoLMtn0/UMb6azcbqXVhWalgH/+w658l2Pu6+fywgbGx+DJ/ya8SPuXDfn2bUAGE7QNA3VrCPVdsVDnhf3ttFfxwE3s+rub1K0aSh63Kdj/3nvLTxz1Gj6NT6t7W5Wh2afZIsHFmcfdPQUPZkPPvufEsveTkEM6xOSzZYgOB7jGbAx8KHhs10PD7eO5qjxSZsa2SuejDN4igMXXvT6gi7Nmpvh2nK6eO/QPtVmd8fQw7Co/kZvA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DF4PR84MB0314;BCL:0;PCL:0;RULEID:;SRVR:DF4PR84MB0314; X-Forefront-PRVS: 0905A6B2C7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(51914003)(377454003)(24454002)(65806001)(65956001)(66066001)(189998001)(86362001)(81166005)(110136002)(36756003)(117156001)(59896002)(4001350100001)(76176999)(87266999)(33656002)(50986999)(47776003)(65816999)(92566002)(23756003)(77096005)(50466002)(42186005)(5004730100002)(3846002)(80316001)(2950100001)(54356999)(2906002)(5008740100001)(586003)(4326007)(83506001)(6116002)(64126003)(230700001)(1096002);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0314;H:[192.168.142.152];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;DF4PR84MB0314;23:Gl5y1+cZI1hDqkfltmsqzc2QRH6BlfRnJXS+KXb?= =?iso-8859-1?Q?+Kg7wYtP1Thhq4CFDreCMRzkiTrG8UwLpspwCxND3ofC/vGTQKg+vrSvYG?= =?iso-8859-1?Q?LZjj0p7Aaj5jGqucn2uJiQnCzsS/6COUNgrkU/2rK2sU/1uB202gd3cryL?= =?iso-8859-1?Q?w5KAcAatT6VeWnmALlyP+S1GPXR7AlvlSwc2JcX4rSJQ6Ms8moh58kl0cV?= =?iso-8859-1?Q?ti3WHkjX9wk8P5KbTxbDkkBMTL4VNW/QNpfxYO4QgEx9Rn6MiMjGBQBtyP?= =?iso-8859-1?Q?qgo0YaWpTti4saAA0rFqAnhSsxSvjTb5QGX2Ut9jwU3vt8PCEbPW44Lx8w?= =?iso-8859-1?Q?EkBzNYv1FTYM+9GsYW0xp7MROnz3EFvemU2341TldZu2JaEfY8ahxoEjTN?= =?iso-8859-1?Q?fMbZrvwvEEY+banU5Eb38Y5y2MYv7sZaHeL/bwwbg+bmXOZ7lXXJRojESS?= =?iso-8859-1?Q?KBZp3SjI8wd/H+8/Mn+fh1KlchqF0bLF7ob1bMdgBfjmC2GHYudiuJlM1k?= =?iso-8859-1?Q?ld5txCuWVyNTCZbEWGf7JSOJ81Z8WVkk5G2KzhcwvnQClBbSlEjAp7r+7I?= =?iso-8859-1?Q?LuAd3dEhC6peqRTrw11DBq0YjB/5A+374sC9xSUNrlrwDZbI1C2HhQZytR?= =?iso-8859-1?Q?dmIL8E1GPFzq+SlT3l7YpAjEmi66Hh3ETcs9DCGm1B625Io0S+Yu+7d8Mq?= =?iso-8859-1?Q?CkQfxAdtEnkYF5lL9b/qgwatbMzVbTJBdrI7jdPyOgwCraY/EQgpAMNEVA?= =?iso-8859-1?Q?NVwZdE0xAb1+IFLBzJprTIa8TUItu5AvuZE5xPR/do8dXvGGDKLQ4s7dZZ?= =?iso-8859-1?Q?nKRcCumDTf6QRBCM2hidmqYkZrlz95RpUxkUOUnkyGBAWx3UXQwcjO9zBi?= =?iso-8859-1?Q?GhNbc360D8fCcGQviE9aHPdFDBuaodm14f1KNaeEfjEEBk+bSCu2/TI+1E?= =?iso-8859-1?Q?2n1lEDvx3+Usr3+0M4iJWfoTGQri3WLbIf4p2L8Q7gvXcKuZRzq6zK5VAI?= =?iso-8859-1?Q?zhRz2PSLGryvFF8seuJeNNnl+Uj8Nr4MmbdWjlnxyX5DHnKDmtbfdAZgtT?= =?iso-8859-1?Q?FAnXzXHka5QxEAumHsysCDvf12/BQm5znGBKFef5QQsVJE+j6k6qUcroiQ?= =?iso-8859-1?Q?AUXJ6jyTBpugVTq+wOvlJxJz2Gg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DF4PR84MB0314;5:zO+SafU3YnBeiUet0qItD3lOA82GpZxy9rM9Bs0iJ/MAsk5GIANJPa5wGdvXa0/4KXptazcZHdJ9zKrRYM4lnfMGhN+hOW8kZnILImORUV0OnZlJ4lLkn43WPKdV9/IN86fxUkX1WH47rZUz0oqITw==;24:LGV931x4jsQsvH9YaHTPQmP3x8be+onEUfEOmuS3TKvd6BA5bQmtYze6pj9RnbJDnoztufGoXBv+SJ0uCtAy4iz3yoeV8B7hYKwR8BiBsH0= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2016 21:39:08.3762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0314 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2016 04:41 PM, Tejun Heo wrote: > Hello, Waiman. > > On Thu, Apr 07, 2016 at 04:37:06PM -0400, Waiman Long wrote: >> I would say that because I am lazy, I don't want compute the deltas every >> time I want to see the effect of running a certain type of workload on the >> statistics counts. I have use case that I need to track 10 or so statistics >> counts and monitor their changes after running a job. It is much more >> convenient to do a reset and see what you get than doing manual subtractions >> to find out. > I don't know. Write a simple script? Even if you wanna keep it in > kernel, you can just have a base counter which offsets the summed up > value on read. > >> I had taken a look at percpu-refcount.[ch]. I think the synchronization code >> is a bit overkill for this purpose as no one really need a very precise >> statistics counts nor precise atomic reset. I would prefer providing an >> optional atomic reset feature with slower statistics count update path for >> the time being. If we come across a use case where we need atomic reset with >> negligible slowdown, we could then refactor the code to use something >> similar to what the percpu-refcount code is doing. > Please either drop reset or make it actually work; otherwise, I don't > think this should go in. > > Thanks. > In this case, I think I will drop this reset functionality. It is not really needed for this patchset. Thanks for the feedback! Cheers, Longman