From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760430AbcHaNeg (ORCPT ); Wed, 31 Aug 2016 09:34:36 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:63827 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbcHaNee (ORCPT ); Wed, 31 Aug 2016 09:34:34 -0400 From: Arnd Bergmann To: Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Mark Rutland , Kukjin Kim , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , Tomasz Figa , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration Date: Wed, 31 Aug 2016 15:33:47 +0200 Message-ID: <5709554.y3Mq6my3Uz@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1472645613-5362-1-git-send-email-k.kozlowski@samsung.com> <6113443.1q3Xq4YM82@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Viir51dojkrhoTnuMiLKH1s0Z1EtcFwWc2BA/mHo/NJJmYRadX0 bBxwoSW7hkbzY+N019tlE2s71/dzFk4HekRcszVV8/vYlWbqiVpSgnT8S2R4Q2qZmiMMlWa 5pw9OHmfjyd1Us7+bHN7AeQjFWDrA448dJnsKCgi3SDrR87VmJDXVId43csm9BpLzbEMYyn BjazeiTWZJWjwp0t48+jQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:CpxFkRpj7/I=:2gLHzERKaTCw5DcNICEC9t 5EW3SjPWWfdjwpiZnEKzg/kEMKUSyGxvisvzMDdDm1SzXZshJ251HJsnBm/U+Hzo6v5tTrpNl Np6MEq+1RCdO8Ui0RdUfuDV4YQrGm6a/Qeh/g1UH9JCdNYpDQrWuChefHnoYOMQPynTSNwSZd OJwUGWvf4L5eOniExI7KOklDlUukf77VbzRpXbRQL+UTzvE3320+ikJLxdFVrX+4dpLvGDemd cRdAZIFdjyUXCDomDVTDI0tXBGZn2p0O8b7ff9jsopqSYJd+i9PKadbodpjgVH0ngC+ET1dlB 3yd7n5NpJeebd9Xpp5MR5KxGPmdYUUxqToG5T+0M7PRHJSxMA/nCr/LgUISZKwnEyaIZOET7G QCkmTAgP84fWMXqGAy/vruHA6OmMdg300+d5obWugt8N1/nl1bK/GNrZ4jFAgfAsHYruB+uSG w8E2/7uGWNMrHNJUaEz+P0YylRcMjYErfbymHGH4ThGf7JJ8O3cGjLzAMBHbP59CWCMTAOivf M48/NnucOkYG51F0gOkDwFZ3uzYUvsCcFP648bxNxcIZNAGppglaW7/zyDVfw3MDBxySq77oz 3tMZRzbsItuSvC2iiIWiJ/Sa8uzbU715XItjZ7HD1UqeLgR+Ekz9CMCuYgC3f5eGCv0TpWLj6 hz87ggI4+b9UpQbpjtwFH1PADMQr1+lBWWMwpXO8W56kBAk8teLbh9PRYVDGTpj500D9dtnb+ ldVrmQdyZwzQdL4M Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 31, 2016 3:07:00 PM CEST Krzysztof Kozlowski wrote: > > Ok, sounds reasonable. I want to convert also older platforms S3C (drive > strengths and pull up/down differ) and arm64 SoC: Exynos7. For the > latter the problem is there is no common place for sharing DTS, except > the headers. However this does not really belong to headers. I guess > some level of duplication might be still exist. We have stuff in the headers that belongs way less there, so I wouldn't mind, but having a separate set of definitions for arm64 also isn't a problem at all. > > I think overall, a better solution would have been to define the > > constants globally (shared with non-exynos) to start with, > > and have the driver translate generic numbers into vendor > > specific ones. Obviously it's too late for that now. > > We could extend driver by adding new bindings accepting generic numbers > (and still backward compatible) but this looks like an overkill. Agreed, that would only make things more confusing, not less. Arnd