From: Marc Zyngier <marc.zyngier@arm.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Noam Camus <noamca@mellanox.com>
Cc: arcml <linux-snps-arc@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v8 3/3] irqchip: add nps Internal and external irqchips
Date: Mon, 11 Apr 2016 15:43:11 +0100 [thread overview]
Message-ID: <570BB7FF.2070306@arm.com> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA23075F4E9D47D@us01wembx1.internal.synopsys.com>
Hi Vineet,
On 11/04/16 15:09, Vineet Gupta wrote:
> On Monday 11 April 2016 06:41 PM, Marc Zyngier wrote:
>>>>> It doesn't mean I really approve of it. The default domain thing is
>>>>> going to end-up biting you in the rear. But hey, better having this
>>>>> supported upstream than leaving these patches up in the air...
>
> Hi Marc,
>
> Aside of this - there's been serious rework of ARC intc / timers code spurred by
> some of your comments for this irqchip driver.
>
> - We now probe timers via DT (so timer irq comes off of DT as well)
> - We have now switched to linear irq domain (vs. legacy)
>
> IMHO a bunch of ugliness / non-desirability remains (there's likely more)
> - calling irq_set_default_host()
> - calling irq_create_mapping with NULL for IPIs
>
> I really want to do things in better way - make it more modern ... hence would
> request you to please take a look at my latest series (I can post the patches here
> if that helps - although it felt I was spamming you and you got pissed off or
> something and were not responding of late :-)
No, it is just that my bandwidth has been max'd out over the past few
months. There is only so many patches I can look at while still being
able to write some code myself, and I may have flagged your emails as
"things to look at when I have time", which may not have happened in a
timely manner - sorry about that.
Just keep me on CC when you repost them, and I'll try to be a bit more
reactive.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2016-04-11 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 18:14 [PATCH v8 0/3] Adding NPS400 drivers Noam Camus
2016-04-03 18:14 ` [PATCH v8 1/3] soc: Support for EZchip SoC Noam Camus
2016-04-11 12:47 ` Daniel Lezcano
2016-04-03 18:14 ` [PATCH v8 2/3] clocksource: Add NPS400 timers driver Noam Camus
2016-04-07 16:57 ` Daniel Lezcano
2016-04-08 8:58 ` Noam Camus
2016-04-03 18:14 ` [PATCH v8 3/3] irqchip: add nps Internal and external irqchips Noam Camus
2016-04-08 9:03 ` Noam Camus
2016-04-11 12:53 ` Marc Zyngier
2016-04-11 13:35 ` Vineet Gupta
2016-04-11 13:42 ` Jason Cooper
[not found] ` <HE1PR05MB1625D947050070BDA6E92557AA940@HE1PR05MB1625.eurprd05.prod.outlook.com>
[not found] ` <570BA01F.2060100@arm.com>
[not found] ` <HE1PR05MB16250C8C5CC09899BB36D84EAA940@HE1PR05MB1625.eurprd05.prod.outlook.com>
[not found] ` <570BA277.5090202@arm.com>
2016-04-11 14:09 ` Vineet Gupta
2016-04-11 14:43 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570BB7FF.2070306@arm.com \
--to=marc.zyngier@arm.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=daniel.lezcano@linaro.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=noamca@mellanox.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome