From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758132AbcDMOSN (ORCPT ); Wed, 13 Apr 2016 10:18:13 -0400 Received: from foss.arm.com ([217.140.101.70]:34866 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753542AbcDMOSM (ORCPT ); Wed, 13 Apr 2016 10:18:12 -0400 Subject: Re: [PATCH V4 2/7] irqchip, GICv3, ITS: Cleanup for ITS domain initialization. To: Tomasz Nowicki , tglx@linutronix.de, jason@lakedaemon.net, rjw@rjwysocki.net, lorenzo.pieralisi@arm.com, robert.richter@caviumnetworks.com, shijie.huang@arm.com, Suravee.Suthikulpanit@amd.com, hanjun.guo@linaro.org References: <1459759975-24097-1-git-send-email-tn@semihalf.com> <1459759975-24097-3-git-send-email-tn@semihalf.com> Cc: al.stone@linaro.org, mw@semihalf.com, graeme.gregory@linaro.org, Catalin.Marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ddaney.cavm@gmail.com, okaya@codeaurora.org From: Marc Zyngier Organization: ARM Ltd Message-ID: <570E551F.608@arm.com> Date: Wed, 13 Apr 2016 15:18:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <1459759975-24097-3-git-send-email-tn@semihalf.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/16 09:52, Tomasz Nowicki wrote: > There is no point to initialize ITS without having msi-controller > property in corresponding DT node. However, its_probe is checking > msi-controller presence at the end, so we can save our time and do that > check prior to its_probe call. Also, for the code clarity purpose, > we put domain initialization to separate function. > > Signed-off-by: Tomasz Nowicki Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny...