From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934165AbdKPJml (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Nov 2017 04:42:41 -0500
Received: from mail-lf0-f42.google.com ([209.85.215.42]:49083 "EHLO
        mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934149AbdKPJme (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Nov 2017 04:42:34 -0500
X-Google-Smtp-Source: AGs4zMYg5+McI2r5u1Q3S1q3PYk+9AqkIEeWftEMn+0svhPBWXSZW259Vy8m1SPjluEwKbqE+zSpqA==
Subject: Re: [PATCH v7 10/13] dt-bindings: Add qcom slimbus controller
 bindings
To: Rob Herring <robh@kernel.org>
Cc: gregkh@linuxfoundation.org, broonie@kernel.org,
        alsa-devel@alsa-project.org, sdharia@codeaurora.org, bp@suse.de,
        poeschel@lemonage.de, treding@nvidia.com, andreas.noever@gmail.com,
        alan@linux.intel.com, mathieu.poirier@linaro.org, daniel@ffwll.ch,
        jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com,
        davem@davemloft.net, james.hogan@imgtec.com,
        michael.opdenacker@free-electrons.com, pawel.moll@arm.com,
        mark.rutland@arm.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        vinod.koul@intel.com, arnd@arndb.de
References: <20171115141043.29202-1-srinivas.kandagatla@linaro.org>
 <20171115141043.29202-11-srinivas.kandagatla@linaro.org>
 <20171116051911.tvl6mioxpbo4h72c@rob-hp-laptop>
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <570e58a7-06dd-7e0c-e427-28b5abc08533@linaro.org>
Date: Thu, 16 Nov 2017 09:42:28 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20171116051911.tvl6mioxpbo4h72c@rob-hp-laptop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for the review,

On 16/11/17 05:19, Rob Herring wrote:
>> +	entry should be used.
>> + - reg-name for slew rate: "slew"
> reg-names
> 
> I'd prefer it be explicit as to which compatibles do or don't have this
> register.
Makes sense, I will take this in before sending next version.
> 
>> +
>> +Example:
>> +
>> +	slim@28080000 {
>> +		compatible = "qcom,apq8064-slim", "qcom,slim";
>> +		reg = <0x28080000 0x2000>,
> error                                    ^
> 
thanks for spotting.. will fix this.
>> +		interrupts = <0 33 0>;
>> +		clocks = <&lcc SLIMBUS_SRC>, <&lcc AUDIO_SLIMBUS_CLK>;
>> +		clock-names = "iface", "core";
>> +		#address-cells = <2>;
>> +		#size-cell = <0>;
>> +
>> +		codec: wcd9310@1,0{
> Use generic node names:
> 
> wcd9310: audio-codec@1,0
Yep, will do that.

thanks,
srini
>