From: Luben Tuikov <luben.tuikov@amd.com>
To: Vladislav Efanov <VEfanov@ispras.ru>
Cc: "David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] drm/sched: Remove redundant check
Date: Fri, 19 May 2023 09:37:08 -0400 [thread overview]
Message-ID: <570f1771-cecc-edf0-185e-f6f76b681684@amd.com> (raw)
In-Reply-To: <20230517125247.434103-1-VEfanov@ispras.ru>
Thanks!
Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>
Applied to drm-misc-fixes.
Regards,
Luben
On 2023-05-17 08:52, Vladislav Efanov wrote:
> The rq pointer points inside the drm_gpu_scheduler structure. Thus
> it can't be NULL.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: c61cdbdbffc1 ("drm/scheduler: Fix hang when sched_entity released")
> Signed-off-by: Vladislav Efanov <VEfanov@ispras.ru>
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 8c183639603e..aea5a90ff98b 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -1141,9 +1141,6 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched)
> for (i = DRM_SCHED_PRIORITY_COUNT - 1; i >= DRM_SCHED_PRIORITY_MIN; i--) {
> struct drm_sched_rq *rq = &sched->sched_rq[i];
>
> - if (!rq)
> - continue;
> -
> spin_lock(&rq->lock);
> list_for_each_entry(s_entity, &rq->entities, list)
> /*
prev parent reply other threads:[~2023-05-19 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 12:52 Vladislav Efanov
2023-05-19 13:37 ` Luben Tuikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570f1771-cecc-edf0-185e-f6f76b681684@amd.com \
--to=luben.tuikov@amd.com \
--cc=VEfanov@ispras.ru \
--cc=airlied@gmail.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®