From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 396AB385503 for ; Tue, 3 Mar 2026 06:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772519668; cv=none; b=aLjzovkOBiqsifnd8TlYHYIL0n0gCDD93Nc9Wnjt+p2Y8KFbgcfIXyHVtSBlN5NRoI7Pcq8dFzwSHFwB8VFpGYdyuBLRpxqdrWv0nNbfr/WUaPSZ1DRIV8+j+k4rDpseZJtlsARMjK7c8E8nH4yYfHVCSGAjfJoCQZzw8736mjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772519668; c=relaxed/simple; bh=4S4QK4WtNL+d/FcHRcbHOxeD9XFze0UE1MX7pgku5wQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=HDHfMK+Y0DLb02yhh2QAnLYQM3Z0Ut4DTW768QPlgbDr8tkHRqRmu26jJfoGkMIfklM9IfUmenKBgYztSv5L4LC9Riz46hkBVSDKtqO0lrNeTJcq4G+u9NwhF2hnOPet5OOsP38PijHcoG5++kN24UKnjnVBswG8RfINpWzz3EM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FMndIkVe; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FMndIkVe" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2be19f05d7dso1838013eec.1 for ; Mon, 02 Mar 2026 22:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772519666; x=1773124466; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=wRKjgkDomqGiNIQtlDhLm04oDbUKMJ/HlWcbSF4/BKw=; b=FMndIkVe9AQG4/qFDBitAM5ZR5S7kozTy83zhgR3ceFd7MYcEFR9/x3HyDgD69pyqs 0i2snSTjJRdv8P7Glabiv0Fwd0wRLK+iRJwA6ycyO4GzCaCbVbnyIQd0cN10WS5EJ6Um eCEAYoXEbuAuaa6LUMc99Am/WJJ+03hu0CEfOpsOT9GE2zCr5rh0DYrooBDfzvcJLXVn Ejki8JqPY4iXpbYopQzSYfMAiMciOR5hLd+biCJ9dKBNH5KuwV2O6YelC1bEUzN+MHXK 7AG0kexAK1TGl44vpjBMi0qSs78/irYpPemNxBduWUBspac0RdCnxoLjdv05/EApqnnj qoSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772519666; x=1773124466; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wRKjgkDomqGiNIQtlDhLm04oDbUKMJ/HlWcbSF4/BKw=; b=g/dJ+1lE2LRUYmLlJvYrF9MQilc5R3JZZ+Bcl4yTve+lcqL5DlUGb1fK8DscRPAvit R0HCjgSdSsQmD3fegWFaG7eW8fvoux+swuHBglZ2e4kmDG19J6dA+VN2UFfZzDXcQ1nW DBwzrSOFtlJqZw8G+4HFgZ7xlWRA6DEIV6gZGSdwwDypn070Yup6sa8kQ8NBIZllWbQc oK9HW1IxVPOSSN837U76HJ6yEnrsF0U9PMQCddsLE8bWv33cX+QiCFqIda57atbTj0Zu q7g0z9H3kdxzID3WubZys8z8H0n8BFtIpEbq1Cy+/BY86TYH1xNFVjQjnOSHiEZh8DsC Nm5Q== X-Forwarded-Encrypted: i=1; AJvYcCUHVVspZ7E6sUDpm+rT3gzj+xIF7BkQYfJUYEHvDVfRT10ZxOSjGY3ZbOKNF4PmPb0MWnGIuJYapwa6Hpg=@vger.kernel.org X-Gm-Message-State: AOJu0YxXAekFCJygTGRJ194JovAcL2Vg2TY5pnaO/YSb235Rll/QAEoA CgpHz7J/MV4aUV6Zf7DUnli7ERYHg9+vjNzo8FV/vQg7TUkpe7zT9AhS X-Gm-Gg: ATEYQzwRo0NoJRtJy9N3980u+yHHvEs0oHHofo8YypWDGiMoxX/z+5+cDLlSQA7GVts tDDxT1SFdwfefc+1gKhhRk+E6Uv9HHZHO+nw6xFbUxX5bVa9E67QnZN9rGGOzxRqXdwcLXe6Iwn BbAPv9QaSZ5soGXblVhw3dYWBrEkFytUV85yX6dWnTY86RL+PmaSU++4R4EmBoRYyGD8yluOvDo SWW7dJ6UelNarqb0LFW4V2Kq1P/FHm61U7D0p9chp6qB2i7BxK1x1rDYvCIqnLg/Rbq9ITJ+PBy M7Rw1dDzLB1fTqiDRahRgcVjT89X7XH0BMORLRI9wDHObjrY3DxLVNDtt6z4u8JWR4VvGzyEFPL 9t9pr+QM5hy5DtGFMYFBtSdZyJUPsuuv9Ixlf3zZJv7pmaUEzX9eIOpM7yTTsBrdbR5DxnQpMn8 zFmNngUKeCFN/+Fyi6E2VMq34JgDdxM4JnDz3Nt9VoVuvrUOX6C5SLCw== X-Received: by 2002:a05:693c:3109:b0:2be:9d3:c8c5 with SMTP id 5a478bee46e88-2be09d3cfa2mr3123023eec.34.1772519666143; Mon, 02 Mar 2026 22:34:26 -0800 (PST) Received: from rzhang1-mobl.sh.intel.com ([192.55.54.43]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bdd1f7e955sm12472463eec.32.2026.03.02.22.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 22:34:25 -0800 (PST) Message-ID: <570f930fcf770119b0edd3453899068876322d91.camel@gmail.com> Subject: Re: [RFC][PATCH 5/6] x86/topo: Fix SNC topology mess From: Zhang Rui To: Peter Zijlstra , "Chen, Yu C" Cc: Tim Chen , linux-kernel@vger.kernel.org, kyle.meyer@hpe.com, vinicius.gomes@intel.com, brgerst@gmail.com, hpa@zytor.com, kprateek.nayak@amd.com, patryk.wlazlyn@linux.intel.com, rafael.j.wysocki@intel.com, russ.anderson@hpe.com, zhao1.liu@intel.com, tony.luck@intel.com, x86@kernel.org, tglx@kernel.org Date: Tue, 03 Mar 2026 14:31:37 +0800 In-Reply-To: <20260302164317.GP1282955@noisy.programming.kicks-ass.net> References: <20260226104909.675623579@infradead.org> <20260226105052.737712686@infradead.org> <334d4edb-b8f4-41fb-aa16-6cb7abeaa21d@intel.com> <20260227130130.GD1395266@noisy.programming.kicks-ass.net> <67cfac6fe0495a533fa3204fa01ee07653029e91.camel@linux.intel.com> <20260302164317.GP1282955@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-03-02 at 17:43 +0100, Peter Zijlstra wrote: > nt On Sat, Feb 28, 2026 at 03:35:26PM +0800, Chen, Yu C wrote: >=20 > > Here we check packages0 and 1, should we check all the packages? >=20 > Might as well I suppose. >=20 > Could you boot queue/x86/topo on an snc-3 machine to verify it > doesn't > explode with all the paranoia on? Hi, Peter, regarding slit_validate() in https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h= =3Dx86/topo&id=3D24ca94ac4b72803a7164b7ad84f06f0e9f0c49df I suppose we want to use=20 WARN_ON_ONCE(!slit_cluster_symmetric(n)) rather than WARN_ON_ONCE(slit_cluster_symmetric(n)); right? I tested the queue/x86/topo plus above change, 1. on GNR 4 sockets with SNC2, no difference about sched_domains in /proc/schedstat compared with upstream 7.0-rc1, plus the below warning is also gone [ 11.439633] ------------[ cut here ]------------ [ 11.440491] sched: Expect only up to 2 packages for GNR or CWF, but saw 4 packages when building sched domains. [ 11.440493] WARNING: arch/x86/kernel/smpboot.c:574 at arch_sched_node_distance+0x133/0x140, CPU#0: swapper/0/1 2. on CWF 2 sockets with SNC3 and CWF 1 socket with SNC3, no difference about sched_domains in /proc/schedstat compared with upstream 7.0-rc1 So Tested-by: Zhang Rui -rui