From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752651AbcDOQSJ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Apr 2016 12:18:09 -0400
Received: from vern.gendns.com ([206.190.152.46]:60909 "EHLO vern.gendns.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752499AbcDOQSG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Apr 2016 12:18:06 -0400
Subject: Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0
To: Sekhar Nori <nsekhar@ti.com>
References: <1460586628-25152-1-git-send-email-david@lechnology.com>
 <1460586628-25152-2-git-send-email-david@lechnology.com>
 <5710C176.3040304@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>,
        Kevin Hilman <khilman@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
From: David Lechner <david@lechnology.com>
Message-ID: <57111433.6080402@lechnology.com>
Date: Fri, 15 Apr 2016 11:17:55 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <5710C176.3040304@ti.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - vern.gendns.com
X-AntiAbuse: Original Domain - vger.kernel.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - lechnology.com
X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed
X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/15/2016 05:24 AM, Sekhar Nori wrote:

>
> This made me notice that num-cs is populated wrongly for spi1. It
> actually has 8 chip selects. This is fine though.

I might as well fix it since I have to make changes anyway. Don't 
remember how I came up with 6.

>
> Also, it will be nice to add pinctrl entries for spi0 like it is done
> for spi1. You will need those anyway for using the interface.

I omitted this on purpose. For my use case, I am using the SPI as 
write-only, so not using the SOMI pin, which is actually muxed as a GPIO 
for something else. So having a pinctl like spi1 is of no use to me. I 
figured if someone needs it, they can add it, otherwise it just is 
wasted space to me.
>
> I prefer DT updates are patches of their own and not combined with code
> updates like this. Can you please split this up?

Ack.