From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752580AbcDOQe0 (ORCPT ); Fri, 15 Apr 2016 12:34:26 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:42245 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbcDOQeY (ORCPT ); Fri, 15 Apr 2016 12:34:24 -0400 X-AuditID: cbfec7f5-f792a6d000001302-12-5711180b77c7 Subject: Re: [PATCH] clk: samsung: exynos7: Don't gate CMU_{CCORE, FSYS0} blocks clock To: Alim Akhtar References: <1460608972-13878-1-git-send-email-alim.akhtar@samsung.com> <570F4BE0.1010102@samsung.com> <5710E082.2050303@samsung.com> Cc: Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, thomas.ab@samsung.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, sboyd@codeaurora.org, mturquette@baylibre.com, tomasz.figa@gmail.com From: Sylwester Nawrocki Message-id: <5711180A.8030809@samsung.com> Date: Fri, 15 Apr 2016 18:34:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <5710E082.2050303@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsVy+t/xa7rcEoLhBstfWlg8mLeNzeL1C0OL TY+vsVp87LnHanF51xw2ixnn9zFZXDzlavHjTDeLRccyRotVu/4wOnB5vL/Ryu5xua+XyWPn rLvsHpuX1Hv0bVnF6PF5k1wAWxSXTUpqTmZZapG+XQJXxu7r29gKvrBVvDm0kaWB8TRrFyMn h4SAiUT3mZVsELaYxIV764FsDg4hgaWMEhPUuxi5gMznjBKn9uxmBqkRFoiQWL3jJiOILSKg KfGso48RoqidUeLatnfsIAlmgRlMEnO3yYHYbAKGEr1H+8AaeAW0JBbdmwu2mEVAVWLhwf1g tijQ0CdzT0LVCEr8mHyPBcTmFNCWmHttHxPIQcwCehL3L2pBjJeX2LzmLfMERoFZSDpmIVTN QlK1gJF5FaNoamlyQXFSeq6RXnFibnFpXrpecn7uJkZIBHzdwbj0mNUhRgEORiUe3gexAuFC rIllxZW5hxglOJiVRHgnCAmGC/GmJFZWpRblxxeV5qQWH2KU5mBREueduet9iJBAemJJanZq akFqEUyWiYNTqoGR+8ElrcRTRxQ3sHCtLj/fN6l8z5XVTD0nn/l+meJQOSfjx8GAk5ErzZfN vvev31jNyPynYtJfsfA9x8OYC/cUpcgLh8xmnbf5h+n0B4GeE9reb6pO596Tt4rLW8PoiMjS HOmIcIMU1/t58/juZPJ57ov3vyh9p9lZffWHpBVFi1/urZVQe1KsxFKckWioxVxUnAgAZ5jT pXwCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/15/2016 02:37 PM, Alim Akhtar wrote: > On 04/14/2016 01:20 PM, Krzysztof Kozlowski wrote: >> > On 04/14/2016 06:42 AM, Alim Akhtar wrote: >>> >> This patch adds CLK_IS_CRITICAL flag to ACLK_CCORE_133 and ACLK_FSYS0_200 >>> >> clocks. These clocks are critical for accessing CMU_CCORE and CMU_FSYS0 >>> >> blocks registers. Let these clocks to be enabled all the time. >>> >> >>> >> Signed-off-by: Alim Akhtar >>> >> --- >>> >> drivers/clk/samsung/clk-exynos7.c | 5 +++-- >>> >> 1 file changed, 3 insertions(+), 2 deletions(-) >> > >> > Reviewed-by: Krzysztof Kozlowski >> > > Thanks Krzysztof, > Sylwester, do you have any concern here? I'm fine with the patch, if it fixes all the issues for you. I will apply it and will likely send it upstream after v4.7-rc1 release. -- Regards, Sylwester