mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, "Doug Berger" <opendmb@gmail.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Marek Behún" <kabel@kernel.org>,
	"Peter Geis" <pgwipeout@gmail.com>,
	Frank <Frank.Sae@motor-comm.com>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 2/3] net: phy: broadcom: Add support for Wake-on-LAN
Date: Mon, 8 May 2023 21:09:45 +0200	[thread overview]
Message-ID: <5711f834-8fc1-4144-bc12-e12388c2808a@lunn.ch> (raw)
In-Reply-To: <20230508184309.1628108-3-f.fainelli@gmail.com>

> Because the Wake-on-LAN configuration can be set long before the system
> is actually put to sleep, we cannot have an interrupt service routine to
> clear on read the interrupt status register and ensure that new packet
> matches will be detected.

Hi Florian

I assume the interrupt is active low, not an edge. And it will remain
active until it is cleared? So on resume, don't you need to clear it?
Otherwise it is already active when entering the next suspend/resume
cycle.

	Andrew

  reply	other threads:[~2023-05-08 19:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08 18:43 [PATCH net-next 0/3] Support for Wake-on-LAN for Broadcom PHYs Florian Fainelli
2023-05-08 18:43 ` [PATCH net-next 1/3] net: phy: Let drivers check Wake-on-LAN status Florian Fainelli
2023-05-08 19:02   ` Andrew Lunn
2023-05-08 19:17     ` Florian Fainelli
2023-05-08 19:18       ` Florian Fainelli
2023-05-08 18:43 ` [PATCH net-next 2/3] net: phy: broadcom: Add support for Wake-on-LAN Florian Fainelli
2023-05-08 19:09   ` Andrew Lunn [this message]
2023-05-08 19:12     ` Florian Fainelli
2023-05-08 19:23   ` Simon Horman
2023-05-09  9:25   ` kernel test robot
2023-05-08 18:43 ` [PATCH net-next 3/3] net: bcmgenet: Add support for PHY-based Wake-on-LAN Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5711f834-8fc1-4144-bc12-e12388c2808a@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Frank.Sae@motor-comm.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=kabel@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=pgwipeout@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®