From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932083AbdJJKJt (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Oct 2017 06:09:49 -0400
Received: from esa1.microchip.iphmx.com ([68.232.147.91]:47506 "EHLO
        esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754894AbdJJKJr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Oct 2017 06:09:47 -0400
X-IronPort-AV: E=Sophos;i="5.42,504,1500966000"; 
   d="scan'208";a="8192943"
Subject: Re: [PATCH 09/15] ARM: dts: at91: sama5d2_xplained: Add charger node
 of pmic.
To: "Yang, Wenyou" <Wenyou.Yang@Microchip.com>,
        <nicolas.ferre@Microchip.com>, <alexandre.belloni@free-electrons.com>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>, <linux@armlinux.org.uk>
CC: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Wenyou Yang <wenyou.yang@atmel.com>
References: <1507565377-1545-1-git-send-email-claudiu.beznea@microchip.com>
 <1507565377-1545-10-git-send-email-claudiu.beznea@microchip.com>
 <d42b60fb-7eac-229c-5e71-303e271c01a0@Microchip.com>
From: m18063 <Claudiu.Beznea@Microchip.com>
Message-ID: <5714eb53-d777-130e-b8bd-f80eda7c96b0@microchip.com>
Date: Tue, 10 Oct 2017 13:09:32 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <d42b60fb-7eac-229c-5e71-303e271c01a0@Microchip.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Wenyou,

On 10.10.2017 03:39, Yang, Wenyou wrote:
> Hi Claudiu,
> 
> 
> On 2017/10/10 0:09, Claudiu Beznea wrote:
>> Add charger device node as a sub-device node of act8945a mfd, move
>> the charger's properties to this node, and use the "interrupts"
>> property to replace "active-semi,irq_gpios" to denote the act8945a
>> charger's irq.
>>
>> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
>> [claudiu.beznea@microchip.com: replace numbers with pin macros]
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> This patch has already applied on at91-dt branch.
> https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=at91-dt&id=4b6ad41f267b8ddabf5dd1b02a318bc74f0b95e9
> 
Thanks, I will remove it from v2.

>> ---
>>   arch/arm/boot/dts/at91-sama5d2_xplained.dts | 23 +++++++++++++++--------
>>   1 file changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> index c7e9ccf2bc87..848ca1b025be 100644
>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> @@ -160,14 +160,6 @@
>>                       compatible = "active-semi,act8945a";
>>                       reg = <0x5b>;
>>                       active-semi,vsel-high;
>> -                    active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>;
>> -                    active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>;
>> -                    active-semi,irq_gpios = <&pioA PIN_PB13 GPIO_ACTIVE_LOW>;
>> -                    active-semi,input-voltage-threshold-microvolt = <6600>;
>> -                    active-semi,precondition-timeout = <40>;
>> -                    active-semi,total-timeout = <3>;
>> -                    pinctrl-names = "default";
>> -                    pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
>>                       status = "okay";
>>                         regulators {
>> @@ -220,6 +212,21 @@
>>                               regulator-always-on;
>>                           };
>>                       };
>> +
>> +                    charger {
>> +                        compatible = "active-semi,act8945a-charger";
>> +                        pinctrl-names = "default";
>> +                        pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
>> +                        interrupt-parent = <&pioA>;
>> +                        interrupts = <PIN_PB13 GPIO_ACTIVE_LOW>;
>> +
>> +                        active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>;
>> +                        active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>;
>> +                        active-semi,input-voltage-threshold-microvolt = <6600>;
>> +                        active-semi,precondition-timeout = <40>;
>> +                        active-semi,total-timeout = <3>;
>> +                        status = "okay";
>> +                    };
>>                   };
>>               };
>>   
> 
> Best Regards,
> Wenyou Yang