From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v2] regulator: s2mps11: Set default ramp delay for S2MPS11 LDOs
Date: Mon, 18 Apr 2016 13:03:22 -0400 [thread overview]
Message-ID: <5715135A.4010402@osg.samsung.com> (raw)
In-Reply-To: <1460986390-9674-1-git-send-email-k.kozlowski@samsung.com>
Hello Krzysztof,
On 04/18/2016 09:33 AM, Krzysztof Kozlowski wrote:
> Driver did not provide default value for ramp delay for LDOs which lead
> to warning in dmesg, e.g. on Odroid XU4:
>
> [ 1.486076] vdd_ldo9: ramp_delay not set
> [ 1.506875] vddq_mmc2: ramp_delay not set
> [ 1.523766] vdd_ldo15: ramp_delay not set
> [ 1.544702] vdd_sd: ramp_delay not set
>
> The datasheet for all the S2MPS1x family is inconsistent here and does
> not specify unambiguously the value of ramp delay for LDO. It mentions
> 30 mV/us in one timing diagram but then omits it completely in LDO
> regulator characteristics table (it is specified for bucks).
>
> However the vendor kernels for Galaxy S5 and Odroid XU3 use values of 12
> mV/us or 24 mV/us.
>
> Without the ramp delay value the consumers do not wait for voltage
> settle after changing it. Although the proper value of ramp delay for
> LDOs is unknown, it seems safer to use at least some value from
> reference kernel than to leave it unset.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-04-18 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 13:33 Krzysztof Kozlowski
2016-04-18 17:03 ` Javier Martinez Canillas [this message]
2016-04-18 19:04 ` Applied "regulator: s2mps11: Set default ramp delay for S2MPS11 LDOs" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5715135A.4010402@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®