mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Bryan O'Donoghue <bod.linux@nxsw.ie>
Cc: jerome.debretagne@gmail.com,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Johannes Berg" <johannes@sipsolutions.net>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Maximilian Luz" <luzmaximilian@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Jeff Johnson" <jjohnson@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, ath12k@lists.infradead.org,
	"Jeff Johnson" <jeff.johnson@oss.qualcomm.com>,
	"Dale Whinham" <daleyo@gmail.com>
Subject: Re: [PATCH v5 2/7] dt-bindings: wireless: ieee80211: Add disable-rfkill property
Date: Mon, 12 Oct 2026 18:38:48 +0200	[thread overview]
Message-ID: <571681d6-67f3-47fe-9a42-dce5aca13c99@oss.qualcomm.com> (raw)
In-Reply-To: <20251220-fervent-mamba-of-sunshine-f680a8@quoll>

On 12/20/25 10:12 AM, Krzysztof Kozlowski wrote:
> On Sat, Dec 20, 2025 at 06:04:00AM +0000, Bryan O'Donoghue wrote:
>> On 20/12/2025 00:21, Jérôme de Bretagne via B4 Relay wrote:
>>> From: Jérôme de Bretagne <jerome.debretagne@gmail.com>
>>>
>>> For some devices, Wi-Fi is entirely hard blocked by default making
>>> the Wi-Fi radio unusable, except if rfkill is disabled as expected
>>> on those models.

[...]

>> Is this really a hardware description though ?
>>
>> Its really more of a logical/functional description. It tells the runtime
>> what todo, not what the hardware is.
>>
>> You could also have a list of quirks in ath12k for this or have a user-space
>> utility look for the appropriate platform device string name and disable
>> rfkill.
>>
>> I think this logic belongs in drivers/net/wireless/ath/ath12k/ triggering on
>> a compat string.
> 
> This is good point. Either this could be deducible from the compatible
> or this should actually describe the hardware and whatever is there
> wired/configured, not what OS should do.

Sorry for digging up an old thread. The board-compatible change is now
I think merged into ath12k, but I'm not sure I like that, as now every
OS consuming this DT has to carry a table of board compatibles (hence
needing updates _every single time_ we want to support a new device),
instead of being able to convey the quirk through the property

Perhaps we could revisit this approach?

Konrad

  parent reply	other threads:[~2026-10-12 16:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-20  0:21 [PATCH v5 0/7] Microsoft Surface Pro 11 support Jérôme de Bretagne via B4 Relay
2025-12-20  0:21 ` [PATCH v5 1/7] dt-bindings: arm: qcom: Document Microsoft Surface Pro 11 Jérôme de Bretagne via B4 Relay
2025-12-20  9:12   ` Krzysztof Kozlowski
2025-12-20  0:21 ` [PATCH v5 2/7] dt-bindings: wireless: ieee80211: Add disable-rfkill property Jérôme de Bretagne via B4 Relay
2025-12-20  6:04   ` Bryan O'Donoghue
2025-12-20  9:12     ` Krzysztof Kozlowski
2025-12-20 14:02       ` Jérôme de Bretagne
2025-12-20 16:05       ` Dmitry Baryshkov
2025-12-22 10:06         ` Konrad Dybcio
2026-10-12 16:38       ` Konrad Dybcio [this message]
2026-10-12 16:53         ` Krzysztof Kozlowski
2026-10-12 18:56           ` Jérôme de Bretagne
2026-10-12 16:53         ` Jeff Johnson
2025-12-22 10:23     ` Hans de Goede
2025-12-22 11:04       ` Krzysztof Kozlowski
2025-12-22 11:45       ` Manivannan Sadhasivam
2025-12-22 12:41         ` Hans de Goede
2025-12-22 13:41           ` Manivannan Sadhasivam
2025-12-22 14:22             ` Hans de Goede
2025-12-23  6:31               ` Manivannan Sadhasivam
2025-12-23  9:23                 ` Jérôme de Bretagne
2025-12-20  0:22 ` [PATCH v5 3/7] dt-bindings: wireless: ath12k: Allow " Jérôme de Bretagne via B4 Relay
2025-12-20  0:22 ` [PATCH v5 4/7] firmware: qcom: scm: allow QSEECOM on Surface Pro 11 Jérôme de Bretagne via B4 Relay
2025-12-20  0:22 ` [PATCH v5 5/7] platform/surface: aggregator_registry: Add Surface Pro 11 (QCOM) Jérôme de Bretagne via B4 Relay
2025-12-20  0:22 ` [PATCH v5 6/7] arm64: dts: qcom: Add support for Surface Pro 11 Jérôme de Bretagne via B4 Relay
2025-12-20  0:22 ` [PATCH v5 7/7] wifi: ath12k: Add support for disabling rfkill via devicetree Jérôme de Bretagne via B4 Relay
2025-12-20  6:07   ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571681d6-67f3-47fe-9a42-dce5aca13c99@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=bod.linux@nxsw.ie \
    --cc=conor+dt@kernel.org \
    --cc=daleyo@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=jerome.debretagne@gmail.com \
    --cc=jjohnson@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®