From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933079AbcDSUNR (ORCPT ); Tue, 19 Apr 2016 16:13:17 -0400 Received: from lists.s-osg.org ([54.187.51.154]:42588 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753080AbcDSUNP (ORCPT ); Tue, 19 Apr 2016 16:13:15 -0400 Subject: Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards To: Krzysztof Kozlowski , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1460965453-5337-1-git-send-email-k.kozlowski@samsung.com> <571510D5.3090406@osg.samsung.com> <5715C629.1030602@samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Javier Martinez Canillas Message-ID: <5716914C.1030102@osg.samsung.com> Date: Tue, 19 Apr 2016 16:13:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <5715C629.1030602@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 04/19/2016 01:46 AM, Krzysztof Kozlowski wrote: > On 04/18/2016 06:52 PM, Javier Martinez Canillas wrote: [snip] >> >> On a related note, the s5m8767 regulator driver parses similar DT properties >> ("s5m8767,pmic-buck-ramp-delay", "s5m8767,pmic-buck2-ramp-enable", etc) that >> are not in Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt. >> >> So those should either be added to the binding doc or removed from the driver >> if are not correct (I don't have documentation for the s5m8767 PMIC but the >> DT properties are not use by any DTS in mainline using the s5m8767 PMIC). > > That's the grey area. :) I mean that instead of making these implemented > bindings an interface, they should rather be converted to standard > regulator bindings. However the device is quite old, not used on newer > boards, so there is no interest in improving this. In the same time > removal of this code is not strictly necessary. Its existence does not hurt. > Fair enough. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America