From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932343AbcDTJCT (ORCPT ); Wed, 20 Apr 2016 05:02:19 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:17730 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966AbcDTJCQ (ORCPT ); Wed, 20 Apr 2016 05:02:16 -0400 X-AuditID: cbfec7f4-f796c6d000001486-57-571745952c20 Subject: Re: [PATCH 2/2] i2c: s3c2410: Check clk_prepare_enable() return value To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1461096641-19788-1-git-send-email-javier@osg.samsung.com> <1461096641-19788-2-git-send-email-javier@osg.samsung.com> Cc: linux-samsung-soc@vger.kernel.org, Wolfram Sang , Kukjin Kim , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <57174593.90307@samsung.com> Date: Wed, 20 Apr 2016 11:02:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1461096641-19788-2-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsVy+t/xq7pTXcXDDb53sVq8ebuGyeL1C0OL /sevmS02Pb7GatHx9wujxeVdc9gsZpzfx2Sx8sQsZgcOj02rOtk8Ni+p99jSf5fdo2/LKkaP k6eesHh83iQXwBbFZZOSmpNZllqkb5fAlXG8cQtLwU32it2TLjM2MK5n62Lk4JAQMJH40WXS xcgJZIpJXLgHEubiEBJYyijx+vYdZgjnGaPEtcOz2ECqhAX8JL6cfMwIYosIhEr8u3ibEaKo mVGiYcdhMIdZYDWjxMeeo2AdbALGEpuXLwGzeQU0JPqWzwTrZhFQlTjzuJkdxBYViJB4Mvck I0SNoMSPyfdYQGxOAXeJGRPPMIKcyiygJ3H/ohZImFlAXmLzmrfMExgFZiHpmIVQNQtJ1QJG 5lWMoqmlyQXFSem5hnrFibnFpXnpesn5uZsYIUH/ZQfj4mNWhxgFOBiVeHgDCkTDhVgTy4or cw8xSnAwK4nwHnAUDxfiTUmsrEotyo8vKs1JLT7EKM3BoiTOO3fX+xAhgfTEktTs1NSC1CKY LBMHp1QDo5v6AYHLlsG+VhME1ma8iJDlPuLhLRhcm36l72Ts5Jhqn3mznFqTb695btR8Tkd8 v7+kfIT4q+aXOx/q9Sl91omIagt4885nw5k/LofSDl//+2jf54KCawbO29+mmOtd/7ySJ2Xn 1R3tIS73TrXOy90oxPRjk0DDwduLg+1Vg/e6TMnRcZsoqsRSnJFoqMVcVJwIAEJB/Mt2AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/19/2016 10:10 PM, Javier Martinez Canillas wrote: > The clk_prepare_enable() function can fail so check the return > value and propagate the error in case of a failure. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c > index 4b873fe9a75b..cb40a3af46e7 100644 > --- a/drivers/i2c/busses/i2c-s3c2410.c > +++ b/drivers/i2c/busses/i2c-s3c2410.c > @@ -1196,7 +1196,12 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) > > /* initialise the i2c controller */ > > - clk_prepare_enable(i2c->clk); > + ret = clk_prepare_enable(i2c->clk); > + if (ret) { > + dev_err(&pdev->dev, "I2C clock enable failed (%d)\n", ret); Just: "I2C clock enable failed\n" The probe error code will be printed anyway. Best regards, Krzysztof