From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD744364053 for ; Fri, 22 May 2026 09:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779440928; cv=none; b=Dijqv9gjE8hWYyHCUjmQMQfYQyeMaYmcwTjEJpQn4xtaJcsjyYJNk3WnhOC4YhOwG8E5X02ZgPhM5NzuS8oUN297nUfDGSo2DI8dA2st/SnJz8dxFLMKYL9ye2jsiITA7bggyIboPLHC3rUb5qyF2UJzB47pMFN5PxD2pK1c66g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779440928; c=relaxed/simple; bh=roRWlgdyFRGvzjwKDlar10VDdu/eL54CKftyh/LTR3k=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=Neu49c3vC1HDVAmQV8mDGH5xNilV+atSN1FscHxZliG3BmbsWFHcCM7lFVY+Xqso/ygjtvLsNZGLFWJzdZhjc2ssY8YA715Zdv1QZyLx2n07uIw0I2kWrOCeShKUxfLu6+Sq5toA2E0rcdFI/yPhn8xWOgILYsa9RRjQcCD8yAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VYHtM0WR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BQ2rdEi6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VYHtM0WR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BQ2rdEi6" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M8lQmW399119 for ; Fri, 22 May 2026 09:08:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mKwTq/x1CgdeyD6mhRAd0X8c1OdQ+gz6M1HFcjRwlpA=; b=VYHtM0WRdfskSNMW rsbGP8eTuOJ0Zb3Uu3HOV3xUpU62nsl1tHo4RVS7s8bcUFBNFMAh9+5OE7zsAzUO /Fi7+bDUMYqnNCa7wa9OYvShXEkIPuWfqNIOv6d/7R0DISZQPEqd3IBgR9VyAoAd v5ZrZeKGitgRiPSr6MLombB2xLWSgyxsVPLt1/9zAe5e0Nj/UX1Qovktr3jW1apY EvoXL8QIbeBkkQAz8CRsPsc3mv70zmQlhRzgGZpC+rs2kSZ2sVaFehscKDUI6Gqa /R/RWrjf6KBRW4ioyoq0tbNeclLzB9T/+5VeWMTA2AuL6HoyoOR/Fau9xvoayaKf ReyHRg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ea5p9ujh4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 09:08:45 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82fa366fb79so9469549b3a.2 for ; Fri, 22 May 2026 02:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779440924; x=1780045724; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=mKwTq/x1CgdeyD6mhRAd0X8c1OdQ+gz6M1HFcjRwlpA=; b=BQ2rdEi6SeyTVz0HwX8CvTsGunGczNrxMfDuBpLVeEnUzG5V22awNeGSQE/sC9w/+0 BLxJ564SRiRfVPkWuve/pvtZ7j9jTdVxDxrsfrA+acAM+1/qSH9hv26JvLzZCcb2HlEU EifPxBTQtQgBncdu0Ot0gjj1oZt7UrxURb8dK827p2YfaseKNMDfWxzdJ0J9eedUTqvk n2DdlntMCyZUtouxhKtrW4TkWSn1TNSPUFei2rTLaM3EKvImK8UcUH6hn+IUPn8jtn2L CKo6656HixKOd5QuXfvRZBFVrFq/u8Er5Hre5O7d2dTBfOjeRNt03z52Ba/G0ynd2lDz pgjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779440924; x=1780045724; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mKwTq/x1CgdeyD6mhRAd0X8c1OdQ+gz6M1HFcjRwlpA=; b=WTYne8T4pWUKcwowLKCHpEAS61lzdcXuAQGih4frSl7OrV0R5CHcs1aWpdiVTmJRER dqtk+pN7nebU/z9qXIzm0jYvfi5QRF0lszL2waXqfhScOOBzM6EKxRFo4YeedCVH4IDV Vqh2i1svhcg3NoW5P8SpSQuWVWv0eW62Ac6pYwOvGrt8z1LrY4drJUsjkYW+h0ncwpDw vOPtE7ku/gT64CUI8PiN4Bk1NsjMVbG5vYBPLcQnogftawHtza1rzll2udpSJyI2WObg e6Fxiu3CRCUYgfJjbFnqHT6DSbs84nq539X1SGmD71oI7ePqcP9vq8TtZ7UGf4v3RS9Y EHEw== X-Forwarded-Encrypted: i=1; AFNElJ/hWjtMV35ZNe4SUetjYyeFwwdmm4jix3oEegiVNnkvNZNwHbjKo/2UdKLmhZ1BrRdC+sJuwgfXCPc43CE=@vger.kernel.org X-Gm-Message-State: AOJu0Yzp7xKFbPy0lU843q10HbcrUEW3P50LyV4hpbf7lWaOctusD7Rb rSqvqNtgJD0R39P9+d7AEGW/EmJYLseyj+bn84BeEabLBelM1BKNfpx4VF6tiKxDoC22us8sjXw //HLrerArH0mjtw8RD/dpijNzufd4tPOc9MYF5swxixmTuhF8p9sDh631+VowvMW3iLQ= X-Gm-Gg: Acq92OGgb8+hde2YstFp1A9AYJW/yqKChaTy1WfsbwQA9c1pPron524eQ+Z7Sparytk 20G+2qDgg5ZBJL7PFIBx49CBe9ZXQbX36Fm1rGrjpwUtS1G9jWl03OKFYvzRyFkcfNNybupP/PE D7sk5uyiqlShWILMhla8/IvQXNTf0awxbj4GzrXll3oJUalg2Wk3Dc5u2qrM9BU3wjllzDISx83 7u6MWpI1jPM34VYqdBvqSi3GyGDD6iJ+JgL5BgLLa24JGXbide3g9LJab+j9Laq74QgaVouvGlo dRaUdkLN+AzpxIcHm21MHTJAH1cNhRf/ffS/gOU/DOyFZTG6aBU5JRlr8BropO9nydik2oMXhto +JA5wFeevy96j4Rli5mh5lnaO4zWegJSsEhpQN4KrcMhx5HEImbmjNHJ6zCMRZBssVK7j44FDHg LaXRAjCh1YETTqg5vV X-Received: by 2002:a05:6a00:244a:b0:83d:a434:f099 with SMTP id d2e1a72fcca58-8415f11f764mr3127961b3a.5.1779440924401; Fri, 22 May 2026 02:08:44 -0700 (PDT) X-Received: by 2002:a05:6a00:244a:b0:83d:a434:f099 with SMTP id d2e1a72fcca58-8415f11f764mr3127918b3a.5.1779440923866; Fri, 22 May 2026 02:08:43 -0700 (PDT) Received: from [10.133.33.160] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164e9ec47sm1576039b3a.32.2026.05.22.02.08.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 02:08:43 -0700 (PDT) Message-ID: <5717a34a-d998-4f4b-832c-08941d49fe54@oss.qualcomm.com> Date: Fri, 22 May 2026 17:08:38 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/5] misc: fastrpc: Fail Audio PD init when reserved memory is missing To: Konrad Dybcio References: <20260515124217.20723-1-jianping.li@oss.qualcomm.com> <20260515124217.20723-4-jianping.li@oss.qualcomm.com> <4f8697b8-d602-4718-bc8f-4bd0dba50040@oss.qualcomm.com> Content-Language: en-US From: Jianping Li Cc: Dmitry Baryshkov , amahesh@qti.qualcomm.com, arnd@arndb.de, abelvesa@kernel.org, jorge.ramirez-ortiz@linaro.org, Ekansh Gupta , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, stable@kernel.org In-Reply-To: <4f8697b8-d602-4718-bc8f-4bd0dba50040@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=DKm/JSNb c=1 sm=1 tr=0 ts=6a101d1d cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=uBSpvLV6fhDO0Xk4A2gA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: BNwsWHBBLcVo9YAz4wHUxEukHL2lKpra X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDA5MCBTYWx0ZWRfX9LhRT34zs42n eduz709gOOvyN4R0+fVnLeTuThXwYpSNyd4tnQOfTD8pZIycWyZTs8EJr/GrLdBYBOU3/LwjzQf R09Bl6Sa32tSJdlZgecbapsRg6LVGP6NhpLSLh78bEgqYhn20hT5sTBEaD+D71JhI2lhz/zZZkS YYesuJ8Xc8pPaOlsBrjMhBPm6Cw8UbsjwKMyoDLC8Yjj3IUzyBtNLY8MgawQohedFw1qzXZCL7j 8SxfuZ7CoDc3Hy7VIyLaK3GNYr/k8ex08KOcS/vOtiK/CotaUcD0LR9qEx1ZXYnQcujRsE3A55e Yc0x7kj/Vawf9oE617mWB4E+KLwEX+AUMRJl/MinHSnKuAe6BMuPwMZkezPeAa94qBtUMPiFfMu xKXkT1qgaMeHzlMzqlztnySxF9KcC3G+Q5/aHgsRZVT0famJ/YXP6XGSyIw8A/Bs1MDj0An5lf2 NOhIN1wVT3QzkMw1k1Q== X-Proofpoint-ORIG-GUID: BNwsWHBBLcVo9YAz4wHUxEukHL2lKpra X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220090 On 5/18/2026 3:59 PM, Konrad Dybcio wrote: > On 5/15/26 2:42 PM, Jianping Li wrote: >> Audio PD static process creation assumes that a reserved-memory >> region is defined in DT and exposed via cctx->remote_heap. >> >> If reserved-memory is missing or incomplete, the driver may pass >> invalid address/size information to the DSP, leading to undefined >> behavior or crashes. >> >> Add explicit validation for remote_heap presence and size before >> sending the memory to DSP, and fail early if the configuration is >> invalid. >> >> Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd") >> Cc: stable@kernel.org >> Signed-off-by: Jianping Li >> --- >> drivers/misc/fastrpc.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c >> index 3c7c3b410d7d..a0337cce77f3 100644 >> --- a/drivers/misc/fastrpc.c >> +++ b/drivers/misc/fastrpc.c >> @@ -1363,6 +1363,12 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, >> args[1].length = inbuf.namelen; >> args[1].fd = -1; >> >> + if (!fl->cctx->remote_heap || >> + !fl->cctx->remote_heap->dma_addr || >> + !fl->cctx->remote_heap->size) { >> + err = -ENOMEM; >> + goto err; > Let's maybe add an UERR() with some context > > Konrad Planning to move this check at the start of this function as per Dmitry's suggestion. I'll also add a dev_dbg log there. Thanks, Jianping.