From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A6C4C4332F for ; Tue, 22 Nov 2022 14:46:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233060AbiKVOqn (ORCPT ); Tue, 22 Nov 2022 09:46:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231956AbiKVOqk (ORCPT ); Tue, 22 Nov 2022 09:46:40 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF87F53ED1 for ; Tue, 22 Nov 2022 06:45:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669128341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fsk8lK1WZRQU/UZ9z9wF0cgfgcye32uUCeIAZWJu+G8=; b=BWKtCE0GHZG2KmmeS/VU09I5dP8HkyG13+QHdV6yGXlXdmXbEMYpjv2r4Wbj7newY6rvoc 5KxI0yIVNpJ0RlsazMueTkVP4fEiniSTo/K89+JxF34Rl9Ua6TLF+JejE3O89EQt9yY9v1 UaMtE0tv0Bij9RZmNX1bjTN3SsJBtT4= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-643-i2m6bOkGPpG0EX5IXUvpxg-1; Tue, 22 Nov 2022 09:45:40 -0500 X-MC-Unique: i2m6bOkGPpG0EX5IXUvpxg-1 Received: by mail-qt1-f197.google.com with SMTP id ay12-20020a05622a228c00b003a52bd33749so14545000qtb.8 for ; Tue, 22 Nov 2022 06:45:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Fsk8lK1WZRQU/UZ9z9wF0cgfgcye32uUCeIAZWJu+G8=; b=I5RIpVJPadB0dm2KxY4KsRzrwo4/l+QG6PCFJx+d5+Z+LRbck4mcgjcY6APcpH+19I ekHg8J7Fke4sVH/4DWPtygL0sr7D/SDyzmyVwGG7EHCt2DJ/gmMbLwXrs9qBIg5f8H7u dQ6JSvnSGMN42cm9DJgXUhf8ga7QUqIyVlpYr4onSmMVRudCfIXx4CBQ76CvasR9Q+K/ dSDXaJ0xEHO/yT57VGwDnApcyQ1xiybLs366nRbUd9WW4xA4AwuuKC5PEWpB91xp3OOZ ubSbbKjau/1Qfu+jLSafc7mOKJTAb6eBf6wK7pUMQo9N/i9mJV+5Bo5G8gaBd8WeDLY6 mbRg== X-Gm-Message-State: ANoB5pnVNUYf4+Cjv9cXQeBdofNZMtk74KsCRRGr8B546vq5Fm2w1grK uHyTdHO0AZOVbX/gCELjNP8znKgZvSf70FBPRe4Y1+B2HQAjqFoYsmUMEI/Tg6fBmluRg9RJaOr rffgBzedY1vXGGX4G8/JutTHC X-Received: by 2002:a05:6214:2c1f:b0:4c6:a598:4fba with SMTP id lc31-20020a0562142c1f00b004c6a5984fbamr3559301qvb.109.1669128340110; Tue, 22 Nov 2022 06:45:40 -0800 (PST) X-Google-Smtp-Source: AA0mqf4sT+9GO6rCCDeZuoCM4ESitr28a4vZ41vYnM9Xlcil3b+82C888e2UG6BQpNHKoBjjojQ3jQ== X-Received: by 2002:a05:6214:2c1f:b0:4c6:a598:4fba with SMTP id lc31-20020a0562142c1f00b004c6a5984fbamr3559276qvb.109.1669128339875; Tue, 22 Nov 2022 06:45:39 -0800 (PST) Received: from gerbillo.redhat.com (146-241-120-203.dyn.eolo.it. [146.241.120.203]) by smtp.gmail.com with ESMTPSA id bm3-20020a05620a198300b006ecfb2c86d3sm10181194qkb.130.2022.11.22.06.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 06:45:39 -0800 (PST) Message-ID: <5718ba71a8755040f61ed7b2f688b1067ca56594.camel@redhat.com> Subject: Re: [PATCH net-next 2/2] bonding: fix link recovery in mode 2 when updelay is nonzero From: Paolo Abeni To: Jonathan Toppins , netdev@vger.kernel.org, Jay Vosburgh Cc: Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org Date: Tue, 22 Nov 2022 15:45:35 +0100 In-Reply-To: <1fe036eb-5207-eccd-0cb3-aa22f5d130ce@redhat.com> References: <38fbc36783d583f805f30fb3a55a8a87f67b59ac.camel@redhat.com> <1fe036eb-5207-eccd-0cb3-aa22f5d130ce@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-11-22 at 08:36 -0500, Jonathan Toppins wrote: > On 11/22/22 05:59, Paolo Abeni wrote: > > Hello, > > > > On Fri, 2022-11-18 at 15:30 -0500, Jonathan Toppins wrote: > > > Before this change when a bond in mode 2 lost link, all of its slaves > > > lost link, the bonding device would never recover even after the > > > expiration of updelay. This change removes the updelay when the bond > > > currently has no usable links. Conforming to bonding.txt section 13.1 > > > paragraph 4. > > > > > > Signed-off-by: Jonathan Toppins > > > > Why are you targeting net-next? This looks like something suitable to > > the -net tree to me. If, so could you please include a Fixes tag? > > > > Note that we can add new self-tests even via the -net tree. > > > > I could not find a reasonable fixes tag for this, hence why I targeted > the net-next tree. When in doubt I think it's preferrable to point out a commit surely affected by the issue - even if that is possibly not the one introducing the issue - than no Fixes as all. The lack of tag will make more difficult the work for stable teams. In this specific case I think that: Fixes: 41f891004063 ("bonding: ignore updelay param when there is no active slave") should be ok, WDYT? if you agree would you mind repost for -net? Thanks, Paolo