On 4/21/2016 4:25 PM, Christian Lamparter wrote: > On Thursday, April 21, 2016 09:15:21 PM Andy Shevchenko wrote: >> The last approach in the commit 8b3444852a2b ("sata_dwc_460ex: move to generic >> DMA driver") to switch to generic DMA engine API wasn't tested on bare metal. >> Besides that we expecting new board support coming with the same SATA IP but >> with different DMA. >> >> This series is targetting the following things: >> - a few bug fixes to the original driver >> - a part to fix the DMA engine usage and in particularly dw_dmac driver >> - move driver to use generic PHY and "dmas" property which leads to update in DTS >> >> The driver has been tested myself on Sam460ex and WD MyBookLive (apollo3g) >> boards. In any case I ask Christian, Måns, and Julian to independently test and >> provide Tested-by tag or error report. > I did a test run on my WD MyBook Live. I applied all the patches in > this series on top of the topic/dw branch of Vinod Koul: > > > Tested-by: Christian Lamparter > --- > results for my old ST3808110AS HDD. filesystem is ext4. > > # hdparm -t /dev/sda > > /dev/sda: > Timing buffered disk reads: 204 MB in 3.02 seconds = 67.51 MB/sec > > # bonnie++ -u mbl > Using uid:1000, gid:1000. > Writing a byte at a time...done > Writing intelligently...done > Rewriting...done > Reading a byte at a time...done > Reading intelligently...done > start 'em...done...done...done...done...done... > Create files in sequential order...done. > Stat files in sequential order...done. > Delete files in sequential order...done. > Create files in random order...done. > Stat files in random order...done. > Delete files in random order...done. > Version 1.97 ------Sequential Output------ --Sequential Input- --Random- > Concurrency 1 -Per Chr- --Block-- -Rewrite- -Per Chr- --Block-- --Seeks-- > Machine Size K/sec %CP K/sec %CP K/sec %CP K/sec %CP K/sec %CP /sec %CP > mbl 496M 98 99 26011 21 17589 20 538 99 80138 39 208.9 8 > Latency 95267us 1409ms 295ms 26947us 9644us 1787ms > Version 1.97 ------Sequential Create------ --------Random Create-------- > mbl -Create-- --Read--- -Delete-- -Create-- --Read--- -Delete-- > files /sec %CP /sec %CP /sec %CP /sec %CP /sec %CP /sec %CP > 16 6959 78 +++++ +++ 5197 40 7250 79 +++++ +++ 4718 37 > Latency 149ms 6742us 212ms 177ms 767us 217ms > 1.97,1.97,mbl,1,1461269771,496M,,98,99,26011,21,17589,20,538,99,80138,39,208.9,8,16,,,,,6959,78,+++++,+++,5197,40,7250,79,+++++,+++,4718,37,95267us,1409ms,295ms,26947us,9644us,1787ms,149ms,6742us,212ms,177ms,767us,217ms > > > > Again on copy partitions .