From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752370AbcDZHoP (ORCPT ); Tue, 26 Apr 2016 03:44:15 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:56703 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbcDZHoN (ORCPT ); Tue, 26 Apr 2016 03:44:13 -0400 X-AuditID: cbfee68d-f79646d000001386-2e-571f1c4a1d1b Message-id: <571F1C4A.1060804@samsung.com> Date: Tue, 26 Apr 2016 16:44:10 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Enric Balletbo Serra , Enric Balletbo i Serra Cc: Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mmc: dw_mmc: Fix UHS tuning on some brand of cards. References: <1461597529-6470-1-git-send-email-enric.balletbo@collabora.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsWyRsSkSNdbRj7cYP8vRosLv1eyWay5fYjR 4vKuOWwWR/73M1ocXxvuwOqx4+4SRo+ds+6ye9y5tofN4/MmuQCWKC6blNSczLLUIn27BK6M Wbd/MxesEKlo2qffwNgh0MXIySEhYCKx68E8JghbTOLCvfVsXYxcHEICKxgl7ky7xgpTtPXp f2aIxFJGiVPN86GqHjBK/NqzGqydV0BLYuem7exdjBwcLAKqErs3OYOE2QR0JLZ/Ow5WIioQ JvFg3V5WiHJBiR+T77GAlIsIpEt8bM4ECTMLJEt0/DvKAmILC3hL9H3oYoRYNYlRomPyTHaQ BKdAsETXgnVgq5gF1CWmTMmF6JWX2LzmLdidEgK72CW2LTrBBpJgERCQ+Db5ENguCQFZiU0H mCH+kpQ4uOIGywRGsVlILpqFMHUWkqkLGJlXMYqmFiQXFCelFxnqFSfmFpfmpesl5+duYgRG 1Ol/z3p3MN4+YH2IUYCDUYmHV2GZXLgQa2JZcWXuIUZToCMmMkuJJucD4zavJN7Q2MzIwtTE 1NjI3NJMSZxXUepnsJBAemJJanZqakFqUXxRaU5q8SFGJg5OqQZGyf8XFKf8YXdeYa6tZ3ly 17q0aS875Bc0xC/kEfF4rmS3/evnVq6qaQoXH8o+DNVs9PfivH1thkaVqEjh6qNVamk6R/fd PZuowCS5RjGKa/OlA7yboxhk5fac6n557/M97umvdvnZhNjwnq+X4+lI3la6oe+K1Ly+YwmZ 9q+LhD8s32/tPo9FiaU4I9FQi7moOBEAm1nvpKMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsVy+t9jAV0vGflwgwt3LC0u/F7JZrHm9iFG i8u75rBZHPnfz2hxfG24A6vHjrtLGD12zrrL7nHn2h42j8+b5AJYohoYbTJSE1NSixRS85Lz UzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOA9ioplCXmlAKFAhKLi5X07TBN CA1x07WAaYzQ9Q0JgusxMkADCWsYM2bd/s1csEKkommffgNjh0AXIyeHhICJxNan/5khbDGJ C/fWs3UxcnEICSxllDjVPB/KecAo8WvPaiaQKl4BLYmdm7azdzFycLAIqErs3uQMEmYT0JHY /u04WImoQJjEg3V7WSHKBSV+TL7HAlIuIpAu8bE5EyTMLJAs0fHvKAuILSzgLdH3oYsRYtUk RomOyTPZQRKcAsESXQvWga1iFlCXmDIlF6JXXmLzmrfMExgFZiHZMAuhahaSqgWMzKsYJVIL kguKk9JzjfJSy/WKE3OLS/PS9ZLzczcxgqP2mfQOxsO73A8xCnAwKvHwVqyQCxdiTSwrrsw9 xCjBwawkwrtXSj5ciDclsbIqtSg/vqg0J7X4EKMpMAQmMkuJJucDE0peSbyhsYmZkaWRuaGF kbG5kjjv4//rwoQE0hNLUrNTUwtSi2D6mDg4pRoYN/6uXbLx8yb56I13zEz7uRrW2DsvObd2 2rzPfletOd9UuL3bslee++HPbsGji7coJtu+aeg2u7nD9vieRSHX9Xj79r4uvsvmr9KnvONo 4ns1a337nbOMnJ8c5xA0T9qlHZvK/yH9yw37o/F7WDhnvrljfPFkAceDdhezPZdmHf6u8i+K Z63YKyWW4oxEQy3mouJEAGKcPxrwAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric, On 04/26/2016 12:29 AM, Enric Balletbo Serra wrote: > Oh, damn, I didn't include the proper tags, > > [PATCH v2] mmc: dw_mmc: Wait for data transfer after response errors. > [PATCH v2] mmc: dw_mmc: Fix UHS tuning on some brand of cards > > should be > > [PATCH v2 0/1] mmc: dw_mmc: Fix UHS tuning on some brand of cards > [PATCH v2 1/1] mmc: dw_mmc: Wait for data transfer after response errors. What changed from patch V1? Anyway, thanks for reminding! :) Best Regards, Jaehoon Chung > > 2016-04-25 17:18 GMT+02:00 Enric Balletbo i Serra > : >> Hi, >> >> I introduced the cover letter to give some background about this. >> >> I have been investigating a problem related to at least one specific sdcard when >> UHS-I is set. The card is not detected due the tuning phase reports a >> failure. Since the problem is only reproduced with a single model of a single >> brand of card, it is probably a card firmware issue, but the card works fine >> on my laptop. >> >> The first attempt to fix this was a patch sent by Doug Anderson [1], but Alim >> Akhtar found that this produced randomly a hung task on Peach-pi. I can confirm >> that it's easy to reproduce the hung task, either, with cold boots or suspend to >> ram tests. >> >> I tried to fix both problems (the original issue and the one introduced by the >> patch) in different ways, but I ended thinking that this second proposal is the >> most simple that solves both issues. So let's try to fix this by handling the >> response CRC error slightly differently when tuning command is happening. >> >> I tested the patch on both platforms, on exynos and on rockhip. I did lots of >> tests and at the moment the patch seems to fix the rockchip issue and don't >> hung on exynos. I'll continue testing meanwhile we discuss about it. >> >> I think the patch, at least, needs the Doug's approval (as he dig into the issue >> before) and the Tested-by Alim. So will be good if you have a slot of time to >> look a bit into this. >> >> Thanks in advance. >> Enric >> >> [1] https://lkml.org/lkml/2015/5/18/495 >> >> Doug Anderson (1): >> mmc: dw_mmc: Wait for data transfer after response errors. >> >> drivers/mmc/host/dw_mmc.c | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> -- >> 2.1.0 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >