From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbcDZLby (ORCPT ); Tue, 26 Apr 2016 07:31:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:60573 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbcDZLbx (ORCPT ); Tue, 26 Apr 2016 07:31:53 -0400 Subject: Re: [PATCH 08/28] mm, page_alloc: Convert alloc_flags to unsigned To: Mel Gorman , Andrew Morton References: <1460710760-32601-1-git-send-email-mgorman@techsingularity.net> <1460710760-32601-9-git-send-email-mgorman@techsingularity.net> Cc: Jesper Dangaard Brouer , Linux-MM , LKML From: Vlastimil Babka Message-ID: <571F51A7.3000300@suse.cz> Date: Tue, 26 Apr 2016 13:31:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1460710760-32601-9-git-send-email-mgorman@techsingularity.net> Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/15/2016 10:59 AM, Mel Gorman wrote: > alloc_flags is a bitmask of flags but it is signed which does not > necessarily generate the best code depending on the compiler. Even > without an impact, it makes more sense that this be unsigned. > > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka