From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m19731117.qiye.163.com (mail-m19731117.qiye.163.com [220.197.31.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6C8B1B4F1F; Thu, 2 Apr 2026 09:05:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.117 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775120719; cv=none; b=QuLKuQpBgok70sKWS7ZjNfiRls1Ls4SGmFfCOey3dSIg74h5BspojvFwhfhfgbxYcSIwec62cCXqUXaf5uGp+LzWCTBmu2mU1KtKcVK7/rMME3378hm6mdlvgAI11JZisxX/PUHPFJwGWYfsfolkP8sqgpYXQzTL6DTrgPTwXro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775120719; c=relaxed/simple; bh=DRAt05Tni72blWzMPGF3tYHdlvNy9axAB6o1IFmDA74=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lA1XVzTch+dmFTTOFsZS0Lko21T31EFS2zd6FN77c2Zx+PAuSdbVC1tIWfSc1kfExgZsrYg05FwrDVQobDuCv+udHY0yYtogjdQbBKGqzOxKjSUOB9yNFI+bPNc8hV90kE0fb75HxPAojT1r6meWelZ1FoRZYfjkGBvLjTTL4qo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=V7uC7gz5; arc=none smtp.client-ip=220.197.31.117 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="V7uC7gz5" Received: from [172.16.12.43] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 394c16600; Thu, 2 Apr 2026 17:05:03 +0800 (GMT+08:00) Message-ID: <571cc85a-3310-4b56-a3ef-3aab698192f6@rock-chips.com> Date: Thu, 2 Apr 2026 17:05:03 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/10] drm/bridge: dw-hdmi: document the output_port field To: Luca Ceresoli , Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: "Kory Maincent (TI.com)" , =?UTF-8?Q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?UTF-8?B?R29yYW4gUmHEkWVub3ZpxIc=?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> <20260330-drm-lcdif-dbanc-v2-5-c7f2af536a24@bootlin.com> Content-Language: en-US From: Damon Ding In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9d4d705f9803a3kunm9716d1d893077 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGUwdTFYaQxgYSRgYTE4fGUhWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSUJNS0 pVSktLVUtZBg++ DKIM-Signature: a=rsa-sha256; b=V7uC7gz5vuVdP8g6TaJjdkO1IMcNDZzxPxF5ZB9843pwJZFzjHlo989JUzBxE48S8cBkykbaMpElWfSZ4w0Z75NrpDPGLCY2530ZMDwiMr7NFEcRXXbBqhmoJ8MSxQIhmOxYwmJk+bYA+fEPPpeM7coiYumKjpFHrZIqrDJkBsU=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=3r+EdcEZhhq3RLdMIkHrVztelasB3cEPklRvu3iRcJY=; h=date:mime-version:subject:message-id:from; Hi Luca, On 4/2/2026 3:46 PM, Luca Ceresoli wrote: > Hello Damon, > > On Tue Mar 31, 2026 at 9:21 AM CEST, Damon Ding wrote: >> On 3/31/2026 3:25 AM, Luca Ceresoli wrote: >>> The meaning of this flag may not be obvious at first sight. >>> >>> Reviewed-by: Liu Ying >>> Tested-by: Martyn Welch >>> Tested-by: Alexander Stein # TQMa8MPxL/MBa8MPxL >>> Signed-off-by: Luca Ceresoli > > Thanks for looking at this series! > >>> @@ -126,6 +126,12 @@ struct dw_hdmi_phy_ops { >>> struct dw_hdmi_plat_data { >>> struct regmap *regm; >>> >>> + /* >>> + * The HDMI output port number must be 1 if the port is described >>> + * in the device tree. 0 if the device tree does not describe the >>> + * next component (legacy mode, i.e. without >>> + * DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when attaching bridge). >>> + */ >>> unsigned int output_port; >>> >>> unsigned long input_bus_encoding; >>> >> >> Tested-by: Damon Ding (on rk3399) > > Uhm, I'm not sure what can be tested in a patch only adding a comment. Did > you mean 'Reviewed-by' maybe? > > Also, I _think_ the best syntax for a comment would be using a '#', not > parentheses, so that would be > > | Tested-by: Damon Ding # on rk3399 > > This is the recommended syntax for the 'Cc: stable' lines [0], at > least. Additionally b4 keeps comments with the '#' as those in [1], while > is discards the ones in parentheses. > > [0] https://docs.kernel.org/process/stable-kernel-rules.html > [1] https://lore.kernel.org/all/2948177.mvXUDI8C0e@steina-w/ > Indeed, '#' is much better. I think we still need to further discuss the various cases around DRM_BRIDGE_ATTACH_NO_CONNECTOR in [PATCH v2 06/10]. Best regards, Damon