From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8374CEB64DC for ; Mon, 3 Jul 2023 07:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229834AbjGCHoq (ORCPT ); Mon, 3 Jul 2023 03:44:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbjGCHop (ORCPT ); Mon, 3 Jul 2023 03:44:45 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABD67C1 for ; Mon, 3 Jul 2023 00:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688370237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+izZ056qkx9wA4inyIESYge9LDOiXeBR8mNGux+wGrY=; b=P3oNtMuBn8BryPEUfLLUrjmx6u5lRpkoCLV6rykUGyuSnYxuu8tOk5rXkDF0BwYqoh2hni xVL9EBL2WW1rphykHkt7hqGNszS2fYPjR5DFO7LNRE1d1hK9+RAxwyorGigE25hNMUBq6s u5Ol/TYIdV/Y+Te9jJIhS7r1kOFH+Ak= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-523-yUKSl3uqMPq6z5xBHPWbzQ-1; Mon, 03 Jul 2023 03:43:54 -0400 X-MC-Unique: yUKSl3uqMPq6z5xBHPWbzQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1C8573806707; Mon, 3 Jul 2023 07:43:54 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA0544087C6A; Mon, 3 Jul 2023 07:43:51 +0000 (UTC) Message-ID: <571e2fbc-ea6a-d231-79f0-37529e05eb98@redhat.com> Date: Mon, 3 Jul 2023 09:43:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 0/2] vduse: add support for networking devices To: Jason Wang , "Michael S. Tsirkin" Cc: xieyongji@bytedance.com, david.marchand@redhat.com, lulu@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, xuanzhuo@linux.alibaba.com, eperezma@redhat.com References: <20230627113652.65283-1-maxime.coquelin@redhat.com> <20230702093530-mutt-send-email-mst@kernel.org> Content-Language: en-US From: Maxime Coquelin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/3/23 08:44, Jason Wang wrote: > On Sun, Jul 2, 2023 at 9:37 PM Michael S. Tsirkin wrote: >> >> On Tue, Jun 27, 2023 at 01:36:50PM +0200, Maxime Coquelin wrote: >>> This small series enables virtio-net device type in VDUSE. >>> With it, basic operation have been tested, both with >>> virtio-vdpa and vhost-vdpa using DPDK Vhost library series >>> adding VDUSE support using split rings layout (merged in >>> DPDK v23.07-rc1). >>> >>> Control queue support (and so multiqueue) has also been >>> tested, but requires a Kernel series from Jason Wang >>> relaxing control queue polling [1] to function reliably. >>> >>> [1]: https://lore.kernel.org/lkml/CACGkMEtgrxN3PPwsDo4oOsnsSLJfEmBEZ0WvjGRr3whU+QasUg@mail.gmail.com/T/ >> >> Jason promised to post a new version of that patch. >> Right Jason? > > Yes. > >> For now let's make sure CVQ feature flag is off? > > We can do that and relax on top of my patch. I agree? Do you prefer a features negotiation, or failing init (like done for VERSION_1) if the VDUSE application advertises CVQ? Thanks, Maxime > Thanks > >> >>> RFC -> v1 changes: >>> ================== >>> - Fail device init if it does not support VERSION_1 (Jason) >>> >>> Maxime Coquelin (2): >>> vduse: validate block features only with block devices >>> vduse: enable Virtio-net device type >>> >>> drivers/vdpa/vdpa_user/vduse_dev.c | 15 +++++++++++---- >>> 1 file changed, 11 insertions(+), 4 deletions(-) >>> >>> -- >>> 2.41.0 >> >